review changes

Author: glevco

tests/tx/scripts/test_script_context.py

@@ -17,15 +17,17 @@
 
 import pytest
 
+from hathor.conf.settings import HathorSettings
 from hathor.transaction import Transaction, TxInput, TxOutput
 from hathor.transaction.exceptions import ScriptError
 from hathor.transaction.scripts.script_context import ScriptContext
 from hathor.transaction.scripts.sighash import SighashAll, SighashBitmask
 
 
-def test_defaults() -> None:
-    settings = Mock()
-    settings.MAX_NUM_OUTPUTS = 99
+@pytest.mark.parametrize(['max_num_outputs'], [(99,), (255,)])
+def test_defaults(max_num_outputs) -> None:
+    settings = Mock(spec_set=HathorSettings)
+    settings.MAX_NUM_OUTPUTS = max_num_outputs
 
     context = ScriptContext(settings=settings, stack=Mock(), logs=[], extras=Mock())
 
@@ -42,7 +44,7 @@ def test_defaults() -> None:
 
     assert context._sighash == SighashAll()
     assert context.get_tx_sighash_data(tx) == tx.get_sighash_all_data()
-    assert context.get_selected_outputs() == set(range(99))
+    assert context.get_selected_outputs() == set(range(max_num_outputs))
 
 
 def test_set_sighash() -> None:

tests/tx/scripts/test_sighash.py

@@ -185,8 +185,8 @@ def test_sighash_bitmask_with_limit(self) -> None:
         atomic_swap_tx_clone.outputs.append(tokens_output)
 
         # Bob adds two change outputs for his HTR, which violates the maximum tx outputs set by Alice
-        htr_output1 = TxOutput(int(genesis_utxo.value / 4), bob_output_script)
-        htr_output2 = TxOutput(int(genesis_utxo.value / 4), bob_output_script)
+        htr_output1 = TxOutput(genesis_utxo.value // 4, bob_output_script)
+        htr_output2 = TxOutput(genesis_utxo.value // 4, bob_output_script)
         atomic_swap_tx_clone.outputs.append(htr_output1)
         atomic_swap_tx_clone.outputs.append(htr_output2)
 

tests/tx/test_scripts.py

@@ -1062,18 +1062,21 @@ def test_op_max_inputs_outputs(self) -> None:
         self.assertEqual(context.stack, [])
 
     def test_execute_op_code(self) -> None:
+        # Test that when `is_opcode_valid` returns False, execution must fail, regardless of the opcode.
         with (
             patch('hathor.transaction.scripts.opcode.is_opcode_valid', lambda _: False),
             self.assertRaises(ScriptError)
         ):
             execute_op_code(opcode=Mock(), context=Mock())
 
+        # Test that when `is_opcode_valid` returns True, execution must fail if it's not a "function opcode".
         with (
             patch('hathor.transaction.scripts.opcode.is_opcode_valid', lambda _: True),
             self.assertRaises(ScriptError)
         ):
             execute_op_code(opcode=Opcode.OP_0, context=Mock())
 
+        # Test that a valid opcode is correctly executed.
         with patch('hathor.transaction.scripts.opcode.op_dup') as op_mock:
             execute_op_code(opcode=Opcode.OP_DUP, context=Mock())