chore: test for the 'strict_status_code' param

Author: luislhl

hathor/healthcheck/resources/healthcheck.py

@@ -47,7 +47,9 @@ def render_GET(self, request):
             checks={c.component_name: [c] for c in components_health_checks},
         )
 
-        if not strict_status_code:
+        if strict_status_code:
+            request.setResponseCode(200)
+        else:
             status_code = health_check.get_http_status_code()
             request.setResponseCode(status_code)
 

tests/resources/healthcheck/test_healthcheck.py

@@ -25,6 +25,29 @@ def test_get_no_recent_activity(self):
         response = yield self.web.get("/health")
         data = response.json_value()
 
+        self.assertEqual(response.responseCode, 503)
+        self.assertEqual(data, {
+            'status': 'fail',
+            'description': ANY,
+            'checks': {
+                'sync': [{
+                    'componentType': 'internal',
+                    'status': 'fail',
+                    'output': HathorManager.UnhealthinessReason.NO_RECENT_ACTIVITY,
+                    'time': ANY
+                }]
+            }
+        })
+
+    @inlineCallbacks
+    def test_strict_status_code(self):
+        """Make sure the 'strict_status_code' parameter is working.
+        The node should return 200 even if it's not ready.
+        """
+        response = yield self.web.get("/health", {b'strict_status_code': b'1'})
+        data = response.json_value()
+
+        self.assertEqual(response.responseCode, 200)
         self.assertEqual(data, {
             'status': 'fail',
             'description': ANY,
@@ -50,6 +73,7 @@ def test_get_no_connected_peer(self):
         response = yield self.web.get("/health")
         data = response.json_value()
 
+        self.assertEqual(response.responseCode, 503)
         self.assertEqual(data, {
             'status': 'fail',
             'description': ANY,
@@ -78,9 +102,10 @@ def test_get_peer_out_of_sync(self):
 
         self.assertEqual(self.manager2.state, self.manager2.NodeState.READY)
 
-        response = yield self.web.get("p2p/readiness")
+        response = yield self.web.get("/health")
         data = response.json_value()
 
+        self.assertEqual(response.responseCode, 503)
         self.assertEqual(data, {
             'status': 'fail',
             'description': ANY,
@@ -109,9 +134,10 @@ def test_get_ready(self):
             self.conn1.run_one_step(debug=True)
             self.clock.advance(0.1)
 
-        response = yield self.web.get("p2p/readiness")
+        response = yield self.web.get("/health")
         data = response.json_value()
 
+        self.assertEqual(response.responseCode, 200)
         self.assertEqual(data, {
             'status': 'pass',
             'description': ANY,