refactor(verification): implement verify_minted_tokens

Author: glevco

hathor/verification/token_creation_transaction_verifier.py

@@ -12,7 +12,6 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 
-from hathor.transaction import Transaction
 from hathor.transaction.exceptions import InvalidToken, TransactionDataError
 from hathor.transaction.token_creation_tx import TokenCreationTransaction
 from hathor.transaction.util import clean_token_string
@@ -29,26 +28,24 @@ def verify(self, tx: TokenCreationTransaction, *, reject_locked_reward: bool = T
         We also overload verify_sum to make some different checks
         """
         super().verify(tx, reject_locked_reward=reject_locked_reward)
+        self.verify_minted_tokens(tx)
         self.verify_token_info(tx)
 
-    def verify_sum(self, tx: Transaction) -> None:
+    def verify_minted_tokens(self, tx: TokenCreationTransaction) -> None:
         """ Besides all checks made on regular transactions, a few extra ones are made:
         - only HTR tokens on the inputs;
         - new tokens are actually being minted;
 
         :raises InvalidToken: when there's an error in token operations
         :raises InputOutputMismatch: if sum of inputs is not equal to outputs and there's no mint/melt
         """
-        assert isinstance(tx, TokenCreationTransaction)
         token_dict = self.get_complete_token_info(tx)
 
         # make sure tokens are being minted
         token_info = token_dict[not_none(tx.hash)]
         if token_info.amount <= 0:
             raise InvalidToken('Token creation transaction must mint new tokens')
 
-        super().verify_sum(tx)
-
     def verify_token_info(self, tx: TokenCreationTransaction) -> None:
         """ Validates token info
         """

tests/tx/test_verification.py

@@ -780,6 +780,7 @@ def test_token_creation_transaction_verify(self) -> None:
         verify_reward_locked_wrapped = Mock(wraps=self.verifiers.token_creation_tx.verify_reward_locked)
 
         verify_token_info_wrapped = Mock(wraps=self.verifiers.token_creation_tx.verify_token_info)
+        verify_minted_tokens_wrapped = Mock(wraps=self.verifiers.token_creation_tx.verify_minted_tokens)
 
         with (
             patch.object(TokenCreationTransactionVerifier, 'verify_pow', verify_pow_wrapped),
@@ -795,6 +796,7 @@ def test_token_creation_transaction_verify(self) -> None:
             patch.object(TokenCreationTransactionVerifier, 'verify_sum', verify_sum_wrapped),
             patch.object(TokenCreationTransactionVerifier, 'verify_reward_locked', verify_reward_locked_wrapped),
             patch.object(TokenCreationTransactionVerifier, 'verify_token_info', verify_token_info_wrapped),
+            patch.object(TokenCreationTransactionVerifier, 'verify_minted_tokens', verify_minted_tokens_wrapped),
         ):
             self.manager.verification_service.verify(tx)
 
@@ -813,6 +815,7 @@ def test_token_creation_transaction_verify(self) -> None:
 
         # TokenCreationTransaction methods
         verify_token_info_wrapped.assert_called_once()
+        verify_minted_tokens_wrapped.assert_called_once()
 
     def test_token_creation_transaction_validate_basic(self) -> None:
         tx = self._get_valid_token_creation_tx()
@@ -907,6 +910,7 @@ def test_token_creation_transaction_validate_full(self) -> None:
         verify_reward_locked_wrapped = Mock(wraps=self.verifiers.token_creation_tx.verify_reward_locked)
 
         verify_token_info_wrapped = Mock(wraps=self.verifiers.token_creation_tx.verify_token_info)
+        verify_minted_tokens_wrapped = Mock(wraps=self.verifiers.token_creation_tx.verify_minted_tokens)
 
         with (
             patch.object(TokenCreationTransactionVerifier, 'verify_parents_basic', verify_parents_basic_wrapped),
@@ -924,6 +928,7 @@ def test_token_creation_transaction_validate_full(self) -> None:
             patch.object(TokenCreationTransactionVerifier, 'verify_sum', verify_sum_wrapped),
             patch.object(TokenCreationTransactionVerifier, 'verify_reward_locked', verify_reward_locked_wrapped),
             patch.object(TokenCreationTransactionVerifier, 'verify_token_info', verify_token_info_wrapped),
+            patch.object(TokenCreationTransactionVerifier, 'verify_minted_tokens', verify_minted_tokens_wrapped),
         ):
             self.manager.verification_service.validate_full(tx)
 
@@ -944,6 +949,7 @@ def test_token_creation_transaction_validate_full(self) -> None:
 
         # TokenCreationTransaction methods
         verify_token_info_wrapped.assert_called_once()
+        verify_minted_tokens_wrapped.assert_called_once()
 
 
 class SyncV1VerificationTest(unittest.SyncV1Params, BaseVerificationTest):