Merge pull request #4107 from Hannah-Sten/exceptions

Avoid a possible UI freeze when finding files to index for native TeX Live installations

Author: PHPirates

CHANGELOG.md

@@ -19,13 +19,14 @@
 
 ### Fixed
 
+* Avoid a possible UI freeze when finding files to index for native TeX Live installations
 * Fix a bug where the documentation popup would not update correctly
 * Fix a few bugs related to the root files cache
 * Fix an issue with the file set cache when opening multiple projects
 * Fix auto compilation not rerunning correctly, by @Ezrnest
 * Fix SumatraPDF forward search not using the correct file, by @Ezrnest
 * Fix extra whitespace when inserting commands in math mode, by @Ezrnest
-* Fix exceptions #4035, #4044, #4058, #4072
+* Fix exceptions #4035, #4044, #4058, #4072, #4074, #4079, #4085, #4086, #4092, #4098 
 * Create run configuration process in background
 
 ## [0.10.3] - 2025-05-16

gradle.properties

@@ -1,4 +1,4 @@
-pluginVersion = 0.10.4-alpha.9
+pluginVersion = 0.10.4-alpha.10
 
 #     Info about build ranges: https://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/build_number_ranges.html
 #    Note that an xyz branch corresponds to version 20xy.z and a since build of xyz.*

src/nl/hannahsten/texifyidea/settings/sdk/NativeTexliveSdk.kt

@@ -3,8 +3,10 @@ package nl.hannahsten.texifyidea.settings.sdk
 import com.intellij.openapi.projectRoots.Sdk
 import com.intellij.openapi.vfs.LocalFileSystem
 import com.intellij.openapi.vfs.VirtualFile
+import nl.hannahsten.texifyidea.util.TexifyCoroutine
 import nl.hannahsten.texifyidea.util.containsAny
 import nl.hannahsten.texifyidea.util.runCommand
+import nl.hannahsten.texifyidea.util.runCommandNonBlocking
 
 /**
  * TeX Live, as installed natively by the OS's package manager.
@@ -23,6 +25,8 @@ class NativeTexliveSdk : TexliveSdk("Native TeX Live SDK") {
         val texmfDistPath: String by lazy {
             "kpsewhich article.sty".runCommand()?.substringBefore("texmf-dist") + "texmf-dist"
         }
+
+        var defaultStyleFilesPath: String? = null
     }
 
     override fun suggestHomePath(): String {
@@ -62,8 +66,17 @@ class NativeTexliveSdk : TexliveSdk("Native TeX Live SDK") {
     }
 
     override fun getDefaultStyleFilesPath(homePath: String): VirtualFile? {
-        val articlePath = runCommand("$homePath/kpsewhich", "article.sty") ?: return null
-        if (articlePath.isBlank()) return null
+        // We cannot call system commands in a blocking way because it may cause freezes (#4102)
+        if (Cache.defaultStyleFilesPath == null) {
+            TexifyCoroutine.runInBackground {
+                // Make sure to not leave it null to avoid unnecessary cache refreshes
+                Cache.defaultStyleFilesPath = runCommandNonBlocking("$homePath/kpsewhich", "article.sty").output ?: ""
+            }
+        }
+
+        val articlePath = Cache.defaultStyleFilesPath
+        if (articlePath.isNullOrBlank()) return null
+
         // Assume article.sty is in tex/latex/base/article.sty
         return LocalFileSystem.getInstance().findFileByPath(articlePath)?.parent?.parent
     }

src/nl/hannahsten/texifyidea/util/files/LatexPackageLocationCache.kt

@@ -46,7 +46,10 @@ object LatexPackageLocationCache {
             val searchPaths = texPaths + File.pathSeparator + (runCommandNonBlocking(executableName, "-show-path=bib").standardOutput ?: ".")
 
             cache = runCommandNonBlocking(executableName, "-expand-path", searchPaths, timeout = 10).standardOutput?.split(File.pathSeparator)
-                ?.flatMap { LocalFileSystem.getInstance().findFileByPath(it)?.children?.toList() ?: emptyList() }
+                ?.flatMap {
+                    val file = LocalFileSystem.getInstance().findFileByPath(it)
+                    (if (file?.isValid == true) file.children?.toList() else null) ?: emptyList()
+                }
                 ?.filter { !it.isDirectory }
                 ?.toSet()
                 ?.associate { it.name to it.path }