Skip to content

Commit 18305c4

Browse files
committed
remove Python 3.5 from support (it's EOL). attempt to fix pypy3 travis test issue again.
1 parent 9fc7997 commit 18305c4

File tree

9 files changed

+23
-20
lines changed

9 files changed

+23
-20
lines changed

.travis.yml

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# travis CI config
22
language: python
33
python:
4-
- 3.5
54
- 3.6
65
- 3.7
76
- 3.8

Readme.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ New code should use Pyro5 if at all possible.
4747
Features
4848
--------
4949

50-
- written in 100% Python so extremely portable, runs on Python 3.5 and newer, and Pypy3
50+
- written in 100% Python so extremely portable, supported on Python 3.6 and newer, and Pypy3
5151
- works between different system architectures and operating systems.
5252
- able to communicate between different Python versions transparently.
5353
- defaults to a safe serializer (`serpent <https://pypi.python.org/pypi/serpent>`_) that supports many Python data types.

docs/source/changelog.rst

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Change Log
55
**Pyro 5.12**
66

77
- fixed error when import Pyro5.server (workaround was to import Pyro5.core before it)
8+
- removed Python 3.5 from the support list (it is EOL). Now requires Python 3.6 or newer
89

910

1011
**Pyro 5.11**

docs/source/install.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ This chapter will show how to obtain and install Pyro.
1212
Compatibility
1313
-------------
1414
Pyro is written in 100% Python. It works on any recent operating system where a suitable
15-
supported Python implementation is available (3.5 or newer).
15+
supported Python implementation is available (3.6 or newer).
1616

1717

1818
.. index::

docs/source/intro.rst

+3-3
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Pyro is a pure Python library and runs on many different platforms and Python ve
2323

2424
Here's a quick overview of Pyro's features:
2525

26-
- written in 100% Python so extremely portable, runs on Python 3.5 and newer, and Pypy3
26+
- written in 100% Python so extremely portable, runs on Python 3.6 and newer, and Pypy3
2727
- works between different system architectures and operating systems.
2828
- able to communicate between different Python versions transparently.
2929
- defaults to a safe serializer (`serpent <https://pypi.python.org/pypi/serpent>`_) that supports many Python data types.
@@ -100,7 +100,7 @@ Using it should be very familiar to current Pyro4 users, however Pyro5 is not co
100100
To allow graceful upgrading, both versions can co-exist due to the new package name
101101
(the same happened years ago when Pyro 3 was upgraded to Pyro4).
102102

103-
Pyro5 requires Python 3.5 or newer. If you're using an onder version of Python, you'll have to stick to Pyro4.
103+
Pyro5 requires Python 3.6 or newer. If you're using an onder version of Python, you'll have to stick to Pyro4.
104104

105105
Pyro5 provides a basic backward-compatibility module so much of existing Pyro4 code doesn't have to
106106
change (apart from adding a single import statement).
@@ -121,7 +121,7 @@ What has been changed since Pyro4
121121

122122
If you're familiar with Pyro4, most of the things are the same in Pyro5. These are the changes though:
123123

124-
- Requires Python 3.5 or newer.
124+
- Requires Python 3.6 or newer.
125125
- the Pyro5 API is redesigned and this library is not compatible with Pyro4 code (although everything should be familiar):
126126

127127
- Pyro5 is the new package name

setup.cfg

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ classifiers =
1818
Natural Language :: Dutch
1919
Operating System :: OS Independent
2020
Programming Language :: Python
21-
Programming Language :: Python :: 3.5
2221
Programming Language :: Python :: 3.6
2322
Programming Language :: Python :: 3.7
2423
Programming Language :: Python :: 3.8

setup.py

-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
import sys
22
from setuptools import setup
33

4-
if sys.version_info < (3, 5):
5-
raise SystemExit("Pyro5 requires Python 3.5 or newer")
6-
74
setup()

tests/test_naming.py

+16-9
Original file line numberDiff line numberDiff line change
@@ -255,12 +255,19 @@ def setup_method(self):
255255
self.storageProvider = Pyro5.nameserver.MemoryStorage()
256256

257257
def teardown_method(self):
258-
self.storageProvider.clear()
258+
self.clearStorage()
259+
self.clearStorage()
259260
self.storageProvider.close()
260261

262+
def clearStorage(self):
263+
try:
264+
self.storageProvider.clear()
265+
except AttributeError:
266+
pass # workaround for weird pypy3 issue on Travis
267+
261268
def testRegister(self):
262269
ns = Pyro5.nameserver.NameServer(storageProvider=self.storageProvider)
263-
self.storageProvider.clear()
270+
self.clearStorage()
264271
ns.ping()
265272
ns.register("test.object1", "PYRO:[email protected]:4444")
266273
ns.register("test.object2", "PYRO:[email protected]:4444")
@@ -299,7 +306,7 @@ def testRegister(self):
299306

300307
def testRemove(self):
301308
ns = Pyro5.nameserver.NameServer(storageProvider=self.storageProvider)
302-
self.storageProvider.clear()
309+
self.clearStorage()
303310
ns.register(Pyro5.core.NAMESERVER_NAME, "PYRO:nameserver@host:555")
304311
for i in range(20):
305312
ns.register("test.%d" % i, "PYRO:obj@host:555")
@@ -316,7 +323,7 @@ def testRemove(self):
316323

317324
def testRemoveProtected(self):
318325
ns = Pyro5.nameserver.NameServer(storageProvider=self.storageProvider)
319-
self.storageProvider.clear()
326+
self.clearStorage()
320327
ns.register(Pyro5.core.NAMESERVER_NAME, "PYRO:nameserver@host:555")
321328
assert ns.remove(Pyro5.core.NAMESERVER_NAME) == 0
322329
assert ns.remove(prefix="Pyro") == 0
@@ -326,7 +333,7 @@ def testRemoveProtected(self):
326333

327334
def testUnicodeNames(self):
328335
ns = Pyro5.nameserver.NameServer(storageProvider=self.storageProvider)
329-
self.storageProvider.clear()
336+
self.clearStorage()
330337
uri = Pyro5.core.URI("PYRO:unicode" + chr(0x20ac) + "@host:5555")
331338
ns.register("unicodename" + chr(0x20ac), uri)
332339
x = ns.lookup("unicodename" + chr(0x20ac))
@@ -335,7 +342,7 @@ def testUnicodeNames(self):
335342

336343
def testList(self):
337344
ns = Pyro5.nameserver.NameServer(storageProvider=self.storageProvider)
338-
self.storageProvider.clear()
345+
self.clearStorage()
339346
ns.register("test.objects.1", "PYRONAME:something1")
340347
ns.register("test.objects.2", "PYRONAME:something2")
341348
ns.register("test.objects.3", "PYRONAME:something3")
@@ -490,7 +497,7 @@ def testMetadataLookupInvalidTypes(self):
490497
ns.yplookup(meta_any="string")
491498

492499
def testMetadata(self):
493-
self.storageProvider.clear()
500+
self.clearStorage()
494501
ns = Pyro5.nameserver.NameServer(storageProvider=self.storageProvider)
495502
# register some names with metadata, and perform simple lookups
496503
ns.register("meta1", "PYRO:meta1@localhost:1111", metadata={"a", "b", "c"})
@@ -560,7 +567,7 @@ def testMetadata(self):
560567
assert ns.count() == 1
561568

562569
def testMetadataAny(self):
563-
self.storageProvider.clear()
570+
self.clearStorage()
564571
ns = Pyro5.nameserver.NameServer(storageProvider=self.storageProvider)
565572
# register some names with metadata, and perform simple lookups
566573
ns.register("meta1", "PYRO:meta1@localhost:1111", metadata={"a", "b", "c"})
@@ -577,7 +584,7 @@ def testMetadataAny(self):
577584
assert "meta2" in result
578585

579586
def testEmptyMetadata(self):
580-
self.storageProvider.clear()
587+
self.clearStorage()
581588
ns = Pyro5.nameserver.NameServer(storageProvider=self.storageProvider)
582589
# register some names with metadata, and perform simple lookups
583590
ns.register("meta1", "PYRO:meta1@localhost:1111", metadata=set())

tox.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tox]
2-
envlist=py35,py36,py37,py38,py39,pypy3
2+
envlist=py36,py37,py38,py39,pypy3
33

44
[testenv]
55
deps=

0 commit comments

Comments
 (0)