lint

Author: max-ostapenko

src/js/histogram.js

@@ -40,13 +40,13 @@ function drawClientSummary(data, options, client) {
 }
 
 function getSummary(data, options) {
-  const summary = getPrimaryMetric(data, options);
+  const summary = getPrimaryMetric(data);
   const metric = new Metric(options, summary);
 
   return metric.toString();
 }
 
-function getPrimaryMetric(data, options) {
+function getPrimaryMetric(data) {
   data = data.filter(o => +o.cdf > 0.5);
   if (!data.length) {
     return '?';

src/js/report.js

@@ -34,21 +34,21 @@ class Report {
   }
 
   bindChangeListener(id) {
-    document.getElementById(id).addEventListener('change', e => {
+    document.getElementById(id).addEventListener('change', (e) => {
       this[id] = e.target.value
       this.updatePermalink();
     });
   }
 
   bindUpdateListener() {
-    document.getElementById('update').addEventListener('click', _ => {
+    document.getElementById('update').addEventListener('click', () => {
       // TODO: Consider using history.replaceState on field changes instead.
       location.href = this.permalink.value;
     });
   }
 
   bindTableVisibilityToggle() {
-    document.body.addEventListener('click', e => {
+    document.body.addEventListener('click', (e) => {
       if (!e.target.classList.contains('show-hide')) {
         return;
       }
@@ -182,7 +182,7 @@ class Report {
     const gridExpanderSelector = '.grid-expansion, .metric-header a';
     Array.from(document.querySelectorAll(gridExpanderSelector)).forEach(btn => {
       const metricId = btn.dataset.metric;
-      btn.addEventListener('click', e => {
+      btn.addEventListener('click', () => {
         this.toggleMetricExpansion(metricId);
       });
     });
@@ -210,7 +210,7 @@ class Report {
 
   getWPT(wptId) {
     const wpt = new WPT(wptId);
-    wpt.fetchResults().then(results => {
+    wpt.fetchResults().then(() => {
       const metrics = wpt.getMetrics(this.report);
       Object.entries(metrics).forEach(([metric, value]) => {
         const options = this.report.metrics.find(m => m.id === metric);

src/js/send-web-vitals.js

@@ -82,7 +82,7 @@ function sendWebVitals() {
           debug_target: attribution.loadState || '(not set)',
         };
         break;
-      case 'INP':
+      case 'INP': {
         const loafAttribution = getLoafAttribution(attribution);
         overrides = {
           debug_event: attribution.interactionType,
@@ -95,6 +95,7 @@ function sendWebVitals() {
           ...loafAttribution
         };
         break;
+      }
       case 'LCP':
         overrides = {
           debug_url: attribution.url,

src/js/techreport/index.js

@@ -89,11 +89,12 @@ class TechReport {
         this.getAllMetricData();
         break;
 
-      case 'category':
+      case 'category': {
         const category = this.filters.category || 'CMS';
         this.initializeReport();
         this.getCategoryData(category);
         break;
+      }
     }
   }
 

src/js/techreport/table.js

@@ -75,7 +75,7 @@ function sortTableBy(dataset, key) {
 }
 
 function getColumnCell(columnConfig, data, date) {
-  const { config, column, client, app, subcategory, metric, endpoint } = columnConfig;
+  const { column, client, app, subcategory, endpoint } = columnConfig;
 
   const _data = data[app]?.find(entry => entry.date === date);
   const endpointData = _data?.[endpoint];

src/js/timeseries.js

@@ -143,7 +143,7 @@ function drawTimeseries(data, options) {
     .then(flagSeries => series.push(flagSeries))
     // If the getFlagSeries request fails (503), catch so we can still draw the chart
     .catch(console.error)
-    .then(_ => {
+    .then( () => {
       const chart = document.getElementById(options.chartId);
       callOnceWhenVisible(chart, () => drawChart(options, series));
     });
@@ -177,7 +177,7 @@ function drawTimeseriesTable(data, options, [start, end]=[-Infinity, Infinity])
     if (!options.timeseries || !options.timeseries.fields) {
       const trMeta = el('tr');
       trMeta.classList.add('meta-row');
-      DEFAULT_COLS.map(col => {
+      DEFAULT_COLS.map(() => {
         return el('td');
       }).forEach(td => trMeta.appendChild(td));
       const th = el('th');
@@ -212,7 +212,7 @@ function drawTimeseriesTable(data, options, [start, end]=[-Infinity, Infinity])
 
 const isDesktop = o => o.client == 'desktop';
 const isMobile = o => o.client == 'mobile';
-const toNumeric = ({client, date, ...other}) => {
+const toNumeric = ({client, ...other}) => {
   return Object.entries(other).reduce((o, [k, v]) => {
     o[k] = +v;
     return o;
@@ -452,7 +452,7 @@ const zip = data => {
     let row = dates[o.timestamp];
     if (row) {
       row.push(o);
-      row.sort((a, b) => a.client == 'desktop' ? -1 : 1)
+      row.sort((a) => a.client == 'desktop' ? -1 : 1)
       return;
     }
     dates[o.timestamp] = [o];