Skip to content

Commit a5740ae

Browse files
Fixes for Feb 2025 tech report (#71)
* fix total_origins * tags fix * fix total_origins * revert total_origins * update providers * cleanup * rename * fix typo * missing infra
1 parent ebe747b commit a5740ae

File tree

8 files changed

+33
-32
lines changed

8 files changed

+33
-32
lines changed

Makefile

+1
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@ tf_plan:
1111

1212
tf_apply:
1313
terraform -chdir=infra/tf init && terraform -chdir=infra/tf apply -auto-approve
14+
cd infra/bigquery-export/ && npm install && npm run buildpack

definitions/output/core_web_vitals/technologies.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ publish('technologies', {
99
clusterBy: ['geo', 'app', 'rank', 'client'],
1010
requirePartitionFilter: true
1111
},
12-
tags: ['crux_ready', 'tech_report'],
12+
tags: ['crux_ready'],
1313
dependOnDependencyAssertions: true
1414
}).preOps(ctx => `
1515
DELETE FROM ${ctx.self()}

definitions/output/reports/cwv_tech_core_web_vitals.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ publish('cwv_tech_core_web_vitals', {
88
partitionBy: 'date',
99
clusterBy: ['rank', 'geo']
1010
},
11-
tags: ['tech_report']
11+
tags: ['crux_ready']
1212
}).preOps(ctx => `
1313
CREATE TEMPORARY FUNCTION GET_VITALS(
1414
records ARRAY<STRUCT<

definitions/output/reports/tech_crux.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ other_summary AS (
360360
361361
STRUCT(
362362
SAFE_CAST(APPROX_QUANTILES(accessibility, 1000)[OFFSET(500)] AS NUMERIC) AS accessibility,
363-
SAFE_CAST(APPROX_QUANTILES(best_practices, 1000)[OFFSET(500)] AS NUMERIC) AS practices,
363+
SAFE_CAST(APPROX_QUANTILES(best_practices, 1000)[OFFSET(500)] AS NUMERIC) AS best_practices,
364364
SAFE_CAST(APPROX_QUANTILES(performance, 1000)[OFFSET(500)] AS NUMERIC) AS performance,
365365
SAFE_CAST(APPROX_QUANTILES(seo, 1000)[OFFSET(500)] AS NUMERIC) AS seo
366366
) AS median_lighthouse_score,

definitions/output/reports/tech_report_categories.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ technology_stats AS (
5252
SELECT
5353
technology,
5454
category_obj AS categories,
55-
SUM(origins) AS total_origins
55+
SUM(origins.mobile + origins.desktop) AS total_origins
5656
FROM ${ctx.ref('reports', 'tech_report_technologies')}
5757
GROUP BY
5858
technology,

infra/tf/.terraform.lock.hcl

+26-26
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

infra/tf/bigquery_export/main.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ data "archive_file" "zip" {
1919
output_path = "./tmp/${var.function_name}.zip"
2020
}
2121

22-
resource "google_storage_bucket_object" "zource" {
22+
resource "google_storage_bucket_object" "source" {
2323
bucket = "gcf-v2-uploads-${var.project_number}-${var.region}"
2424
name = "${var.function_name}_${data.archive_file.zip.id}.zip"
2525
source = data.archive_file.zip.output_path

infra/tf/functions.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ locals {
33
}
44

55
resource "google_project_iam_member" "project" {
6-
for_each = toset(["roles/bigquery.jobUser", "roles/dataform.serviceAgent", "roles/run.invoker", "roles/run.jobsExecutorWithOverrides"])
6+
for_each = toset(["roles/bigquery.jobUser", "roles/dataform.serviceAgent", "roles/run.invoker", "roles/run.jobsExecutorWithOverrides", "roles/datastore.user", "roles/storage.objectUser"])
77

88
project = local.project
99
role = each.value

0 commit comments

Comments
 (0)