fix bug: CommonTabLayout first setCurrentTab() cause indicator not show

Author: H07000223

CHNAGELOG.md

@@ -43,4 +43,8 @@ Version 1.4.0 *(2015-11-11)*
 
 Version 1.4.2 *(2015-12-9)*
 ----------------------------
-* new added tablayout
+* new added tablayout
+
+Version 1.4.4 *(2015-12-11)*
+----------------------------
+* fix bug: CommonTabLayout first setCurrentTab() cause indicator not show

FlycoTabLayout_Lib/build.gradle

@@ -3,15 +3,15 @@ apply plugin: 'com.android.library'
 //apply plugin: 'com.jfrog.bintray'
 
 // 这个version是区分library版本的，因此当我们需要更新library时记得修改这个version
-version = "1.4.2"
+version = "1.4.4"
 android {
     compileSdkVersion 23
     buildToolsVersion "22.0.1"
 
     defaultConfig {
         minSdkVersion 8
         targetSdkVersion 23
-        versionCode 142
+        versionCode 144
         versionName version
     }
     buildTypes {

FlycoTabLayout_Lib/src/main/java/com/flyco/tablayout/CommonTabLayout.java

@@ -149,7 +149,7 @@ private void obtainAttributes(Context context, AttributeSet attrs) {
         TypedArray ta = context.obtainStyledAttributes(attrs, R.styleable.CommonTabLayout);
 
         indicatorStyle = ta.getInt(R.styleable.CommonTabLayout_tl_indicator_style, 0);
-            indicatorColor = ta.getColor(R.styleable.CommonTabLayout_tl_indicator_color, Color.parseColor(indicatorStyle == STYLE_BLOCK ? "#4B6A87" : "#ffffff"));
+        indicatorColor = ta.getColor(R.styleable.CommonTabLayout_tl_indicator_color, Color.parseColor(indicatorStyle == STYLE_BLOCK ? "#4B6A87" : "#ffffff"));
         indicatorHeight = ta.getDimension(R.styleable.CommonTabLayout_tl_indicator_height,
                 dp2px(indicatorStyle == STYLE_TRIANGLE ? 4 : (indicatorStyle == STYLE_BLOCK ? -1 : 2)));
         indicatorWidth = ta.getDimension(R.styleable.CommonTabLayout_tl_indicator_width, dp2px(indicatorStyle == STYLE_TRIANGLE ? 10 : -1));
@@ -242,6 +242,7 @@ private void addTab(final int position, View tabView) {
             public void onClick(View v) {
                 int position = (Integer) v.getTag();
                 if (currentTab != position) {
+                    isFirstSet = false;
                     setCurrentTab(position);
                     if (listener != null) {
                         listener.onTabSelect(position);
@@ -374,6 +375,7 @@ public void onAnimationUpdate(ValueAnimator animation) {
     }
 
     private boolean isFirstDraw = true;
+    private boolean isFirstSet = true;
 
     @Override
     protected void onDraw(Canvas canvas) {
@@ -479,7 +481,12 @@ public void setCurrentTab(int currentTab) {
             fragmentChangeManager.setFragments(currentTab);
         }
         if (indicatorAnimEnable) {
-            calcOffset();
+            if (isFirstSet) {
+                invalidate();
+                isFirstSet = false;
+            } else {
+                calcOffset();
+            }
         } else {
             invalidate();
         }

README.md

@@ -45,7 +45,7 @@ dependencies{
     compile 'com.android.support:support-v4:23.1.1'
     compile 'com.nineoldandroids:library:2.4.0'
     compile 'com.flyco.roundview:FlycoRoundView_Lib:1.1.2@aar'
-    compile 'com.flyco.tablayout:FlycoTabLayout_Lib:1.4.2@aar'
+    compile 'com.flyco.tablayout:FlycoTabLayout_Lib:1.4.4@aar'
 }
 ```
 

README_CN.md

@@ -44,7 +44,7 @@ dependencies{
     compile 'com.android.support:support-v4:23.1.1'
     compile 'com.nineoldandroids:library:2.4.0'
     compile 'com.flyco.roundview:FlycoRoundView_Lib:1.1.2@aar'
-    compile 'com.flyco.tablayout:FlycoTabLayout_Lib:1.4.2@aar'
+    compile 'com.flyco.tablayout:FlycoTabLayout_Lib:1.4.4@aar'
 }
 ```
 

app/build.gradle

@@ -22,9 +22,9 @@ android {
 dependencies {
     compile fileTree(dir: 'libs', include: ['*.jar'])
     compile 'com.android.support:appcompat-v7:23.1.1'
-//    compile project(':FlycoTabLayout_Lib')
+    compile project(':FlycoTabLayout_Lib')
 
-    compile 'com.flyco.tablayout:FlycoTabLayout_Lib:1.4.2@aar'
-    compile 'com.flyco.roundview:FlycoRoundView_Lib:1.1.2@aar'
-    compile 'com.nineoldandroids:library:2.4.0'
+//    compile 'com.flyco.tablayout:FlycoTabLayout_Lib:1.4.4@aar'
+//    compile 'com.flyco.roundview:FlycoRoundView_Lib:1.1.2@aar'
+//    compile 'com.nineoldandroids:library:2.4.0'
 }

app/src/main/java/com/flyco/tablayoutsamples/ui/CommonTabActivity.java

@@ -107,6 +107,7 @@ public void onTabReselect(int position) {
 
             }
         });
+        tl_8.setCurrentTab(2);
 
         //显示未读红点
         tl_1.showDot(2);