Skip to content

Commit 95e045f

Browse files
authored
Fixed Parameterization
1 parent 4bce158 commit 95e045f

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

Source/Applications/Wave Demo Apps/UpdateWAVMetaData/Program.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,12 @@ static int Main(string[] args)
9494
if (Convert.ToInt32(connection.ExecuteScalar(database.ParameterizedQueryString("SELECT COUNT(*) FROM Device WHERE Acronym = {0}", "acronym"), acronym)) == 0)
9595
{
9696
parameterizedQuery = database.ParameterizedQueryString("INSERT INTO Device(NodeID, Acronym, Name, ProtocolID, FramesPerSecond, " +
97-
"MeasurementReportingInterval, ConnectionString, Enabled) VALUES({7}, {0}, {1}, {2}, {3}, {4}, {5}, {6})",
97+
"MeasurementReportingInterval, ConnectionString, Enabled) VALUES({0}, {1}, {2}, {3}, {4}, {5}, {6}, {7})",
9898
"acronym", "name", "protocolID", "framesPerSecond", "measurementReportingInterval",
99-
"connectionString", "enabled");
99+
"connectionString", "enabled", "nodeID");
100100

101101
// Insert new device record
102-
connection.ExecuteNonQuery(parameterizedQuery, acronym, name, protocolID, sourceWave.SampleRate, 1000000, $"wavFileName={FilePath.GetAbsolutePath(sourceFileName)}; connectOnDemand=true; outputSourceIDs={acronym}; memoryCache={useMemoryCache}", database.Bool(true), nodeID);
102+
connection.ExecuteNonQuery(parameterizedQuery, acronym, name, protocolID, sourceWave.SampleRate, 1000000, $"wavFileName={FilePath.GetAbsolutePath(sourceFileName)}; connectOnDemand=true; outputSourceIDs={acronym}; memoryCache={useMemoryCache}", database.Bool(true), database.Guid(nodeID));
103103
int deviceID = Convert.ToInt32(connection.ExecuteScalar(database.ParameterizedQueryString("SELECT ID FROM Device WHERE Acronym = {0}", "acronym"), acronym));
104104
string pointTag;
105105
int lastPhasorIndex = 0;

Source/Libraries/Adapters/MySqlAdapters/MySqlOutputAdapter.cs

+16-4
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,23 @@ protected override void ProcessMeasurements(IMeasurement[] measurements)
177177
{
178178
// Create the command string to insert the measurement as a record in the table.
179179
IDbCommand command = m_connection.CreateCommand();
180-
command.Parameters.Add(measurement.ID);
181-
command.Parameters.Add((long)measurement.Timestamp);
182-
command.Parameters.Add(measurement.AdjustedValue);
180+
IDataParameter measurementIDParameter = command.CreateParameter();
181+
IDataParameter timeStampParameter = command.CreateParameter();
182+
IDataParameter valueParameter = command.CreateParameter();
183183

184-
command.CommandText = "INSERT INTO Measurement VALUES ({0}, {1}, {2})";
184+
measurementIDParameter.Name = "@measurementID";
185+
timeStampParameter.Name = "@timeStamp";
186+
valueParameter.Name = "@adjustedValue";
187+
188+
measurementIDParameter.Value = measurement.ID;
189+
timeStampParameter.Value = (long)measurement.Timestamp;
190+
valueParameter.Value = measurement.AdjustedValue;
191+
192+
command.Parameters.Add(measurementIDParameter);
193+
command.Parameters.Add(timeStampParameter);
194+
command.Parameters.Add(valueParameter);
195+
196+
command.CommandText = "INSERT INTO Measurement VALUES (@measurementID, @timeStamp, @adjustedValue)";
185197
command.ExecuteNonQuery();
186198

187199
}

Source/Libraries/GSF.TimeSeries/Configuration/DatabaseConfigurationLoader.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ public override void Augment(DataSet configuration)
330330

331331
try
332332
{
333-
database.Connection.ExecuteNonQuery("DELETE FROM TrackedChange WHERE ID <= {0}",latestVersion);
333+
database.Connection.ExecuteNonQuery("DELETE FROM TrackedChange WHERE ID <= {0}", latestVersion);
334334
}
335335
catch (Exception ex)
336336
{

0 commit comments

Comments
 (0)