Skip to content

We need to start to consider the plan for adopting the keycloak #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dadiorchen opened this issue Dec 20, 2023 · 6 comments
Open

We need to start to consider the plan for adopting the keycloak #449

dadiorchen opened this issue Dec 20, 2023 · 6 comments
Assignees

Comments

@dadiorchen
Copy link
Collaborator

Currently, keycloak has been deployed to prod/dev, so let's try to figure out how do we integrate the wallet api with keycloak.

So thoughts on my side:

  • The integration seems not so complcated, we just need to bind the user id from keycloak, and let keycloak delegate all the auth & auth stuff.
  • But because the current user system are used for clients, we need to do a smooth migration and maybe let them work parallelly for a while, and consider the transition steps/plan.
@dadiorchen
Copy link
Collaborator Author

This PR #458 is a good reference, feel free to copy the code from it.

@z3347906
Copy link

z3347906 commented Apr 4, 2025

Spoke to @yunchipang - she mentioned Daniel will take on this project (as confirmed by Cynthia)

this issue will be closed after he adds integration tests to pr#458 where features have already been implemented.
currently pending for a new task to be assigned

@z3347906
Copy link

z3347906 commented Apr 9, 2025

Spoke to Daniel to chase up on this

@z3347906
Copy link

Daniel confirmed that he had to do some work on the API beyond just the integration tests, but it's all coming together

@cynthiabondi
Copy link

@z3347906 Any indication on when this will be complete?

@z3347906
Copy link

Spoke to @daniel - multi stage project (api added to cloak, release to data environment) api implemented and deployed -> can be closed.

However, need to work on the wallet app & wallet admin client with app developer -> need to discuss with @dadiorchen & @daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Status: 🌱 Backlog
Development

Successfully merging a pull request may close this issue.

4 participants