Skip to content

Updated changelog for 1.8 #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Updated changelog for 1.8 #630

wants to merge 1 commit into from

Conversation

danuw
Copy link
Collaborator

@danuw danuw commented Apr 28, 2025

Pull Request

Issue Number: (Link to Github Issue or Azure Dev Ops Task/Story)

Summary

One sentence summary of PR

Changes

  • List of comprehensive changes

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.

Is this a breaking change?

If yes, what workflow does this break?

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #628

@danuw danuw requested a review from vaughanknight as a code owner April 28, 2025 23:15
@danuw danuw added v1.8 Ready for Review PR Ready for review with the GSF team for merge labels Apr 28, 2025
@danuw
Copy link
Collaborator Author

danuw commented Apr 29, 2025 •
edited
Loading

cc @YaSuenag - no code was changed in case you have any idea please?

It says the below, likely related to the JSON samples being removed - do they still need to be around for the tests?
Unhandled exception. CarbonAware.Exceptions.ConfigurationException: No data sources are configured

@danuw danuw mentioned this pull request Apr 29, 2025
Open
13 tasks
@YaSuenag
Copy link
Member

It says the below, likely related to the JSON samples being removed - do they still need to be around for the tests?

Yes, we neeed to set both DataSources__EmissionsDataSource and DataSources__Configurations__Json__Type into environment variables. I overlooked this, sorry.

We have to set them as following. Can you fix? otherwise I can fix, but I will send PR tonight or later.

carbon-aware-sdk/.github/workflows/1-pr.yaml

Lines 126 to 127 in ed28d43

DataSources__EmissionsDataSource: Json
DataSources__Configurations__Json__Type: JSON

@YaSuenag YaSuenag mentioned this pull request Apr 30, 2025
Open
6 tasks
@YaSuenag
Copy link
Member

@danuw
I fixed the problem in #632 . All tests in this PR should be passed when you merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughanknight vaughanknight Awaiting requested review from vaughanknight vaughanknight is a code owner

Assignees
No one assigned
Labels
Ready for Review PR Ready for review with the GSF team for merge v1.8
Projects
Carbon Aware SDK
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Release Notes for 1.8
2 participants
@danuw @YaSuenag