Skip to content

Commit eb8e056

Browse files
committed
Addressed KP comments
Signed-off-by: Juan Zuluaga <[email protected]>
1 parent a156556 commit eb8e056

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

docs/architecture/decisions/0014-dynamic-datasource-registration.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Accepted
66

77
## Context
88

9-
Decouple the data sources from the SDK into their own nuget packages and create a mechanism to allow auto discovery and dynamic registration. This will allow for new data sources to be plugged in with minimum configuration and dependency on the existing code base.
9+
Decouple the data sources from the SDK into their own NuGet packages and create a mechanism to allow auto discovery and dynamic registration. This will allow for new data sources to be plugged in with minimum configuration and dependency on the existing code base.
1010

1111
## Decision
1212

@@ -43,13 +43,13 @@ To modify this interaction and to make it more dynamic, these are things that re
4343

4444
- Packaging
4545

46-
Current Data Source project is not allowed to be packaged (nuget package), which would require how this is going to be done in terms of, what the package contains, versioning and where to publish it.
46+
Current Data Source project is not allowed to be packaged (NuGet package, see `<IsPackable>` property on one of the Data Source projects), which would require how this is going to be done in terms of, what the package contains, versioning and where to publish it.
4747

4848
Effort Level: **Medium**
4949

5050
- Load, Register and Instantiate
5151

52-
Using technics like **Reflection** and **Assembly Discovery**, it would be possible to load Data Sources assemblies and instantiate classes that implements the interfaces that are available.
52+
Using techniques like **Reflection** and **Assembly Discovery**, it would be possible to load Data Sources assemblies and instantiate classes that implements the interfaces that are available.
5353
As an example, this could be done via a Data Source class loader
5454

5555
```c#
@@ -83,7 +83,7 @@ To modify this interaction and to make it more dynamic, these are things that re
8383

8484
- GSF Enhancements
8585

86-
Given the fact the current registration is done using D.I., GSF library would require to be changed and enhanced to accommodate discovery, how to load the assemblies that are available and that implement Data Sources interfaces. Also understand the configuration that comes from the manifest, in such a way that all the required properties are available.
86+
Given the fact the current registration is done using Dependency Injection, GSF library would require to be changed and enhanced to accommodate discovery, how to load the assemblies that are available and that implement Data Sources interfaces. Also understand the configuration that comes from the manifest, in such a way that all the required properties are available.
8787

8888
Effort Level: **Medium**
8989

0 commit comments

Comments
 (0)