[fix] block in close

In case that close() is called while doing
read operation, the close() call is blocked and whole application
is stucked. Shut-down of socket will resolve this issue and releases
thread blocked at readline().

Author: richard78917

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## 0.7.0 (2020-XX-XX)
 
+- Fixed issue when threads are blocked on close while reading, #11 by @richard78917
+
 ## 0.6.0 (2020-01-08)
 
 - Added Python 3.8.* support, #10

pynats/client.py

@@ -154,6 +154,7 @@ def connect(self) -> None:
         self._recv(INFO_RE)
 
     def close(self) -> None:
+        self._socket.shutdown(socket.SHUT_RDWR)
         self._socket_file.close()
         self._socket.close()
 
@@ -279,7 +280,11 @@ def _readline(self, *, size: int = None) -> bytes:
         read = io.BytesIO()
 
         while True:
-            line = cast(bytes, self._socket_file.readline())
+            raw_bytes = self._socket_file.readline()
+            if not raw_bytes:
+                raise RuntimeError("unable to read from socket")
+
+            line = cast(bytes, raw_bytes)
             read.write(line)
 
             if size is not None: