Skip to content

Manifests are not deployed when reference from another config #9782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pengux opened this issue Apr 8, 2025 · 2 comments
Open

Manifests are not deployed when reference from another config #9782

pengux opened this issue Apr 8, 2025 · 2 comments

Comments

@pengux
Copy link

pengux commented Apr 8, 2025

Config:

# skaffold.yaml
apiVersion: skaffold/v4beta12
kind: Config
metadata:
  name: cfg
requires:
  - configs: ["cfg2"]
---
apiVersion: skaffold/v4beta12
kind: Config
metadata:
  name: cfg2
manifests:
  rawYaml:
    - skaffold-namespace.yaml
deploy:
  kubectl:
# skaffold-namespace.yaml
apiVersion: v1
kind: Namespace
metadata:
  name: test

Running skaffold dev -vdebug does not create the namespace but instead show this log line:

DEBU[0000] manifests with tagged images:apiVersion: v1
kind: Namespace
metadata:
  name: test  subtask=0 task=Render
DEBU[0000] manifests with labels apiVersion: v1
kind: Namespace
metadata:
  name: test  subtask=-1 task=DevLoop

What I'm trying to achieve is to have a namespace created before deploying releases to that custom namespace, is this not the right approach?

@mjlshen
Copy link

mjlshen commented Apr 29, 2025

I don't know why this is, but I ran into a similar thing and found that manifests is no longer a top-level key? https://skaffold.dev/docs/design/config/

I was able to get this to work using deploy instead, e.g.

# skaffold.yaml
apiVersion: skaffold/v4beta12
kind: Config
metadata:
  name: cfg
requires:
  - configs: ["cfg2"]
---
apiVersion: skaffold/v4beta12
kind: Config
metadata:
  name: cfg2
deploy: # instead of manifests
  rawYaml:
    - skaffold-namespace.yaml
deploy:
  kubectl:

@pengux
Copy link
Author

pengux commented Apr 30, 2025

@mjlshen that doesn't work for me as it returns the error ...mapping key "deploy" already defined...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants