Skip to content

Commit e1bd270

Browse files
authored
chore: upgrade dependencies (#8431)
* fix dependency confilicts and fix tests * chore: fix tests * chore: fix tests and lint issues * chore: fix ko test and lint issues
1 parent 4c9c341 commit e1bd270

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+1592
-2495
lines changed

cmd/skaffold/app/cmd/config/list_test.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ default-repo: value
6565
multi-level-repo: true
6666
local-cluster: true
6767
insecure-registries:
68-
- bad.io
69-
- worse.io
68+
- bad.io
69+
- worse.io
7070
`,
7171
},
7272
{
@@ -90,7 +90,7 @@ insecure-registries:
9090
multi-level-repo: true
9191
local-cluster: true
9292
insecure-registries:
93-
- mediocre.io
93+
- mediocre.io
9494
`,
9595
},
9696
{
@@ -116,10 +116,10 @@ global:
116116
multi-level-repo: true
117117
local-cluster: true
118118
insecure-registries:
119-
- mediocre.io
119+
- mediocre.io
120120
kubeContexts:
121-
- kube-context: this_is_a_context
122-
default-repo: value
121+
- kube-context: this_is_a_context
122+
default-repo: value
123123
`,
124124
},
125125
{

cmd/skaffold/app/cmd/filter_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ spec:
9999
var b bytes.Buffer
100100
err := runFilter(context.TODO(), &b, false, test.buildArtifacts)
101101
t.CheckNoError(err)
102-
t.CheckDeepEqual(test.expected, b.String())
102+
t.CheckDeepEqual(test.expected, b.String(), testutil.YamlObj(t.T))
103103
})
104104
}
105105
}

cmd/skaffold/app/cmd/fix_test.go

+8-3
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ import (
2222
"os"
2323
"testing"
2424

25+
"github.com/google/go-cmp/cmp"
26+
2527
"github.com/GoogleContainerTools/skaffold/v2/pkg/skaffold/schema/latest"
2628
v1 "github.com/GoogleContainerTools/skaffold/v2/pkg/skaffold/schema/v1"
2729
"github.com/GoogleContainerTools/skaffold/v2/testutil"
@@ -34,10 +36,12 @@ func TestFix(t *testing.T) {
3436
targetVersion string
3537
output string
3638
shouldErr bool
39+
cmpOptions cmp.Options
3740
}{
3841
{
3942
description: "v1alpha4 to latest",
4043
targetVersion: latest.Version,
44+
cmpOptions: []cmp.Option{testutil.YamlObj(t)},
4145
inputYaml: `apiVersion: skaffold/v1alpha4
4246
kind: Config
4347
build:
@@ -75,6 +79,7 @@ deploy:
7579
{
7680
description: "v1alpha1 to latest",
7781
targetVersion: latest.Version,
82+
cmpOptions: []cmp.Option{testutil.YamlObj(t)},
7883
inputYaml: `apiVersion: skaffold/v1alpha1
7984
kind: Config
8085
build:
@@ -104,6 +109,7 @@ deploy:
104109
{
105110
description: "v1alpha1 to v1",
106111
targetVersion: v1.Version,
112+
cmpOptions: []cmp.Option{testutil.YamlObj(t)},
107113
inputYaml: `apiVersion: skaffold/v1alpha1
108114
kind: Config
109115
build:
@@ -161,8 +167,7 @@ build:
161167

162168
var b bytes.Buffer
163169
err := fix(&b, cfgFile, "", test.targetVersion)
164-
165-
t.CheckErrorAndDeepEqual(test.shouldErr, err, test.output, b.String())
170+
t.CheckErrorAndDeepEqual(test.shouldErr, err, test.output, b.String(), test.cmpOptions)
166171
})
167172
}
168173
}
@@ -211,6 +216,6 @@ deploy:
211216
output, _ := os.ReadFile(cfgFile)
212217

213218
t.CheckNoError(err)
214-
t.CheckDeepEqual(expectedOutput, string(output))
219+
t.CheckDeepEqual(expectedOutput, string(output), testutil.YamlObj(t.T))
215220
})
216221
}

0 commit comments

Comments
 (0)