Skip to content

Commit 8421ff8

Browse files
authored
chore: remove latest tagging in release process 2.0 (#8985)
* chore: remove latest tagging from relase process * chore: configure minikube to a static version in github ci (#8951) * chore: .. * chore: make minikube version a variable
1 parent 25aeee7 commit 8421ff8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/integration-linux.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ jobs:
2020
ko_version: [0.4.0]
2121
kompose_version: [1.21.0]
2222
kpt_version: [1.0.0-beta.13]
23+
minikube_version: [1.30.1]
2324
gcloud_sdk_version: [410.0.0]
2425
container_structure_tests_version: [1.8.0]
2526
integration_test_partitions: [0, 1, 2, 3]
@@ -116,10 +117,10 @@ jobs:
116117
echo '{}' > ${HOME}/.docker/config.json
117118
mkdir -p ${HOME}/.m2/ && cp ./hack/maven/settings.xml ${HOME}/.m2/settings.xml
118119
119-
- name: Install Minikube from minikube master branch @HEAD and start cluster
120+
- name: Install Minikube and start cluster
120121
if: ${{ env.NON_DOCS_FILES_CHANGED != 0 }}
121122
run: |
122-
curl -Lo minikube https://storage.googleapis.com/minikube-builds/master/minikube-linux-amd64
123+
curl -Lo minikube https://github.com/kubernetes/minikube/releases/download/v${{ matrix.minikube_version }}/minikube-linux-amd64
123124
sudo install minikube /usr/local/bin/minikube
124125
minikube start --profile=minikube --driver=docker
125126

Makefile

-1
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ release: $(BUILD_DIR)/VERSION
149149
--build-arg VERSION=$(VERSION) \
150150
-f deploy/skaffold/Dockerfile \
151151
--target release \
152-
-t gcr.io/$(GCP_PROJECT)/skaffold:latest \
153152
-t gcr.io/$(GCP_PROJECT)/skaffold:$(VERSION) \
154153
.
155154

0 commit comments

Comments
 (0)