change default (#118)

Author: adamfweidman

package-lock.json

@@ -245,7 +245,7 @@ export function setDefaultOptions(
     per_link_options: {},
     total_synthetic_timeout_millis: 60000,
     screenshot_options: {
-      capture_condition: ApiCaptureCondition.FAILING,
+      capture_condition: ApiCaptureCondition.NONE,
       storage_location: '',
     },
   };

packages/synthetics-sdk-broken-links/src/options_func.ts

@@ -269,7 +269,7 @@ describe('GCM Synthetics Broken Links Navigation Functionality', async () => {
         link_start_time: 'NA',
         link_end_time: 'NA',
         is_origin: false,
-        screenshot_output: successfulScreenshotOuput,
+        screenshot_output: emptyScreenshotOutput,
       };
 
       expect(synLinkResult)
@@ -326,7 +326,7 @@ describe('GCM Synthetics Broken Links Navigation Functionality', async () => {
         link_start_time: 'NA',
         link_end_time: 'NA',
         is_origin: false,
-        screenshot_output: successfulScreenshotOuput,
+        screenshot_output: emptyScreenshotOutput,
       };
 
       expect(synLinkResult)

packages/synthetics-sdk-broken-links/test/unit/navigation_func.spec.ts

@@ -18,6 +18,7 @@ import { expect } from 'chai';
 // Internal Project Files
 import {
   BrokenLinksResultV1_BrokenLinkCheckerOptions_LinkOrder,
+  BrokenLinksResultV1_BrokenLinkCheckerOptions_ScreenshotOptions_CaptureCondition as ApiCaptureCondition,
   ResponseStatusCode,
   ResponseStatusCode_StatusClass,
 } from '@google-cloud/synthetics-sdk-api';
@@ -95,6 +96,10 @@ describe('GCM Synthetics Broken Links options_func suite testing', () => {
       },
     };
     expect(options.per_link_options).to.deep.equal(link_options);
+
+    expect(options.screenshot_options?.capture_condition).to.equal(
+      ApiCaptureCondition.NONE
+    );
   });
 
   describe('validateInputOptions', () => {