Skip to content

Java 15 -> 16 #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 22, 2021
Merged

Java 15 -> 16 #391

merged 12 commits into from
Mar 22, 2021

Conversation

ttomsu
Copy link

@ttomsu ttomsu commented Mar 16, 2021

No description provided.

@ttomsu ttomsu requested a review from a team March 16, 2021 16:21
@ttomsu
Copy link
Author

ttomsu commented Mar 16, 2021

Seems errorprone isn't happy:

java.lang.IllegalAccessError: class com.google.errorprone.BaseErrorProneJavaCompiler (in unnamed module @0x38c55a8a) cannot access class com.sun.tools.javac.api.BasicJavacTask (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.api to unnamed module @0x38c55a8a
	at com.google.errorprone.BaseErrorProneJavaCompiler.addTaskListener(BaseErrorProneJavaCompiler.java:94)
	at com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:34)
	at jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:255)
	at jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:229)
	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.prepareCompiler(JavacTaskImpl.java:204)
	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:101)
	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.invocationHelper(JavacTaskImpl.java:152)
	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
	at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
	at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:126)
	at org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:174)
	at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1134)
	at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:187)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:957)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:289)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:193)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
	at org.apache.maven.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:39)
	at org.apache.maven.wrapper.WrapperExecutor.execute(WrapperExecutor.java:122)
	at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:55)

Tried with both Oracle JDK 16 and Azul Zulu 16 - no dice.

@elefeint
Copy link
Contributor

Java 16 is serious about Unsafe deprecations; that's probably why.

@meltsufin
Copy link
Member

We should probably file this issue on the errorprone repo.

@meltsufin meltsufin mentioned this pull request Mar 18, 2021
Closed
@meltsufin
Fix Kotlin Sample for JDK 16
4e05af6 
Remove `--illegal-access=permit` when https://youtrack.jetbrains.com/issue/KT-44624j is fixed.
@meltsufin
Fix Datastore CGLIB usage on JDK 16
089ba29 
Fixes:
```
org.springframework.cglib.core.CodeGenerationException: java.lang.IllegalAccessException-->module java.base does not open java.util to unnamed module @2b834e36
	at com.google.cloud.spring.data.datastore.core.DatastoreTemplateTests.saveTestNotInterfaceLazy(DatastoreTemplateTests.java:571)
Caused by: java.lang.IllegalAccessException: module java.base does not open java.util to unnamed module @2b834e36
	at com.google.cloud.spring.data.datastore.core.DatastoreTemplateTests.saveTestNotInterfaceLazy(DatastoreTemplateTests.java:571)
```
@meltsufin
move --illegal-access=permit to github action
11c9479
@meltsufin
Try GITHUB_ENV instead of env
129e579
@meltsufin
try a different way for GITHUB_ENV
411f8a6
@meltsufin
env.MAVEN_OPTS
e640197
@meltsufin
Copy link
Member

If anyone needs to test JDK 16 build locally, here's a useful docker command:
(from project root)

docker run -it -v `pwd`:/scg -v /Users/${USER}/.m2:/root/.m2 -w /scg openjdk:16 ./mvnw clean install -e

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@meltsufin meltsufin requested review from dzou and elefeint March 22, 2021 20:39
elefeint
elefeint approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@elefeint elefeint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting... gnarly.
Do you want to maybe file followup issues to get the datastore reflection fixed, and errorprone removed?

This was referenced Mar 22, 2021
Closed
Closed
Closed
@meltsufin meltsufin merged commit f0d7d58 into GoogleCloudPlatform:main Mar 22, 2021
kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this pull request Oct 20, 2022
@kateryna216 @meltsufin
Java 15 -> 16 (GoogleCloudPlatform#391)
99c67f3 
* Update errorprone

* Remove Lombok

* Fix Kotlin Sample for JDK 16

* Fix Datastore CGLIB usage on JDK 16

* Add --illegal-access=permit to open up internal JDK modules

Co-authored-by: Mike Eltsufin <[email protected]>
prash-mi pushed a commit that referenced this pull request Jun 20, 2023
@dependabot
Bump assertj-core from 3.19.0 to 3.20.0 (#391)
4b64efb 
Bumps [assertj-core](https://github.com/assertj/assertj-core) from 3.19.0 to 3.20.0.
- [Release notes](https://github.com/assertj/assertj-core/releases)
- [Commits](assertj/assertj@assertj-core-3.19.0...assertj-core-3.20.0)

---
updated-dependencies:
- dependency-name: org.assertj:assertj-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elefeint elefeint elefeint approved these changes

@dzou dzou Awaiting requested review from dzou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ttomsu @elefeint @meltsufin @dzou