Resolve references descendants for subclasses

[THCoulon]

I'm the same guy from the issue #356

• I'm not an expert of this repository since I learned how to use it this week.
• I let you guys handle the correctness of this merge

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[THCoulon]

@googlebot I signed it!

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[THCoulon]

1. Forgot to re-enable the linter (<maven-checkstyle-plugin.skip>false</maven-checkstyle-plugin.skip>)
2. The CLA need to be confirmed for my company

[meltsufin]

@THCoulon Thanks for opening the PR, are you still waiting for confirmation on the CLA?

[THCoulon]

@googlebot I signed it!

[THCoulon]

Yep it's been signed today.

[meltsufin]

@THCoulon Thanks! Can you please fix up the checkstyle errors before we start reviewing this?

[THCoulon]

Finally ! I had some really big problems to use your coding style within Intellij.

I hope everything's okay

[meltsufin]

DatastoreTemplateTests seem to be failing. Also, can you please undo any formatting changes to code that you didn't modify? It makes it hard to review with all of those additional deltas. Thanks!

[THCoulon]

@meltsufin Thanks you for your time and patience !

Also, can you please undo any formatting changes to code that you didn't modify? It makes it hard to review with all of those additional deltas

Just to be sure:

I imported this configuration https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml seen from https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/main/CONTRIBUTING.md.

And then imported this configuration on top of the previous one https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/main/src/eclipse/eclipse-code-formatter.xml.

Then I had to tweak a lot of parameters from the code styling configuration to make it compatible with your checkstyle plugin.

Did I do something wrong ?

But yeah I'll revert back to the previous commit and do the checking again and ensure that it doesn't modify your code. I totally understand that reviewing DatastoreTemplate in this state is a nightmare 💩.

DatastoreTemplateTests seem to be failing

As we discussed in my issue. DatastoreTemplate is failing, Do you want me to modify the unit tests ? I was afraid to modify them because of misunderstanding the logic.

[ttomsu]

@THCoulon Apologies for the difficulty using the checkstyle formatter. We inherited that from when this project rolled up under the Spring Cloud organization and I, too, frequently run into issues with it. It's currently an important-but-not-urgent for us to roll that back and apply our own, preferably automated, way to ensure the code is formatted (sort of like gofmt if you've ever used that tool).

[THCoulon]

Something is still wrong ?

I managed to fix everything. Yet, the new functionality is not tested inside the unit package.

Apologies for the difficulty using the checkstyle formatter

It's just taking more time to format by hand instead of just simply formatting the whole project. Anyway, Thank you for you concern.

[meltsufin]

@THCoulon I added some more polish commits. See if you're OK with those changes.
Otherwise, the PR looks good from my end.
Thanks for the hard work digging through the Spring Data Datastore code, which is not intuitive at all, and ultimately needs to be refactored.

[sonarqubecloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

48.0% Coverage
0.0% Duplication

[THCoulon]

@meltsufin 100% Approved.

To be honest I need these modifications . Now they are in good hands.