Skip to content

docs: update secret manager documentation #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Feb 6, 2025

This PR explains the introduction of the sm@ syntax introduced by #3411

From its description:
We will introduce support for resolving values of the form sm@secret_id in addition to the already existing sm://secret_id format. Users should move away from sm:// and use sm@ instead. Usage of sm:// will raise a warning about this being removed in the future. This has been tested using spring-framework:6.2.2-SNAPSHOT.

The introduction of this syntax was suggested in a discussion of a regression caused by spring-framework:6.2.1 - see spring-projects/spring-framework#34124

This PR explains the introduction of the `sm@` syntax
@diegomarquezp diegomarquezp requested a review from a team as a code owner February 6, 2025 18:54
Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you mind adding some context to the pr description? So if we come back to it and forget, we still have a reminder why this recommendation was made. If you got any links from Spring for recommending this new syntax will be great.

@diegomarquezp
Copy link
Contributor Author

LGTM. Do you mind adding some context to the pr description? So if we come back to it and forget, we still have a reminder why this recommendation was made. If you got any links from Spring for recommending this new syntax will be great.

@zhumin8 thanks for the review!
I have modified the description explaining how the new support for Spring Cloud 2024 has most of the context, plus the discussion with the spring team where they suggest this syntax.

@diegomarquezp diegomarquezp enabled auto-merge (squash) February 6, 2025 20:33
@diegomarquezp diegomarquezp requested a review from zhumin8 February 6, 2025 21:38
@diegomarquezp diegomarquezp merged commit 11f862e into main Feb 7, 2025
58 checks passed
@diegomarquezp diegomarquezp deleted the diegomarquezp-patch-2 branch February 7, 2025 20:41
diegomarquezp added a commit that referenced this pull request Feb 10, 2025
This PR explains the introduction of the `sm@` syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants