Skip to content

fix: handle null primary keys between parent and child objects #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix: handle null primary keys between parent and child objects #3179

merged 2 commits into from
Sep 4, 2024

Conversation

ldetmer
Copy link
Contributor

@ldetmer ldetmer commented Aug 29, 2024

In the case that parent and child have multiple primary keys, do not fail key match validation if both have a null value.

@ldetmer ldetmer requested a review from a team as a code owner August 29, 2024 20:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ldetmer ldetmer merged commit 42c69b6 into main Sep 4, 2024
76 of 77 checks passed
@ldetmer ldetmer deleted the bugfix_326100838 branch September 4, 2024 13:49
@release-please release-please bot mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldetmer @burkedavison