feat: configurable expiration policy on auto-created subscriptions (#2876) (@jmitash) #2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2894) * Add properties for Binder expiration policy * Set Expiration Policy when creating Subscription * Treat non-positive durations as "never expire" * Use Google Java formatting
meltsufin
reviewed
May 16, 2024
...java/com/google/cloud/spring/stream/binder/pubsub/provisioning/PubSubChannelProvisioner.java
Outdated
Show resolved
Hide resolved
burkedavison
commented
May 16, 2024
meltsufin
requested changes
May 17, 2024
Co-authored-by: Mike Eltsufin <[email protected]>
Co-authored-by: Mike Eltsufin <[email protected]>
Co-authored-by: Mike Eltsufin <[email protected]>
Co-authored-by: Mike Eltsufin <[email protected]>
Co-authored-by: Mike Eltsufin <[email protected]>
Co-authored-by: Mike Eltsufin <[email protected]>
|
1 similar comment
|
meltsufin
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #2894
Author: @jmitash