fix: update generate-library-list.sh for duplicate api_shortnames #2873
Conversation
| @@ -5,7 +5,7 @@ on: | |||
| branch_name: | |||
| description: PR branch name | |||
| required: true | |||
| default: "renovate/main-gcp-libraries-bom.version" | |||
| default: "renovate/gcp-libraries-bom.version" | |||
There was a problem hiding this comment.
Is this change intentional?
There was a problem hiding this comment.
Yep - it's intentional. You can see the correct branch name here:
on #2866
There was a problem hiding this comment.
Thanks, I see that main-gcp-libraries-bom is still referenced on line 20 below, which I think probably needs to be updated as well. Do you mind updating it too?
| # Determine distribution_name | ||
| distribution_name=$(echo "$config" | jq -r '.distribution_name' // "") | ||
| if [ -z "$distribution_name" ]; then | ||
| distribution_name="com.google.cloud:google-cloud-${unique_module_name}" |
There was a problem hiding this comment.
Did we get the logic from here? It will not work for non-cloud apis, but I think we are not publishing SpringCodeGen for them anyway, so we should be fine.
There was a problem hiding this comment.
Yep, that's correct. And yeah I assumed as much, but I've added an explicit comment about that now
|
I tested this latest iteration locally and it produced a correct |
Generate Spring Auto-Configurations is currently failing on
securitycenter's module due it having a duplicate api_shortname (https://github.com/googleapis/google-cloud-java/blob/main/generation_config.yaml#L1666).This updates the script to get the values needed from
generation_config.yamlrather than looping throughgoogle-cloud-javafolders and mimics the hermetic build script logic for those values. It useslibrary_nameif it exists (which is the unique moniker if there is a duplicateapi_shortname).It removes
languageas a variable as I didn't see it being used elsewhere in the script.This also updates the default value of the PR branch name to the correct value.