fix: include schema name in table name #2510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spanner databases contain both system schemas and a user schema. The current Spring Data Spanner implementation assumes that all table names in a database are unique, but this is not true if a user creates a table that is equal to the name of a system table in one of the system schemas. Additionally, Spanner could introduce support for user-defined named schemas in the future. This would increase the probability that a single database contains multiple tables with the same name, but in different schemas. This change fixes any problems that might occur if a database contains multiple tables with the same name in different schemas. The change does not attempt to implement full support for using multiple different schemas with Spring Cloud Data Spanner.
|
burkedavison
approved these changes
Jan 11, 2024
meltsufin
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spanner databases contain both system schemas and a user schema. The current Spring Data Spanner implementation assumes that all table names in a database are unique, but this is not true if a user creates a table that is equal to the name of a system table in one of the system schemas.
Additionally, Spanner could introduce support for user-defined named schemas in the future. This would increase the probability that a single database contains multiple tables with the same name, but in different schemas.
This change fixes any problems that might occur if a database contains multiple tables with the same name in different schemas. The change does not attempt to implement full support for using multiple different schemas with Spring Cloud Data Spanner.