Add support for binder customizers #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ConsumerEndpointCustomizer<PubSubInboundChannelAdapter>` and `ProducerMessageHandlerCustomizer<PubSubMessageHandler>` user beans can now be provided to customize the Pub/Sub binder. Fixes: #182.
|
Kudos, SonarCloud Quality Gate passed! |
ttomsu
approved these changes
Jan 5, 2021
elefeint
approved these changes
Jan 5, 2021
| @Test | ||
| public void testProducerAndConsumerCustomizers() { | ||
| baseContext.withUserConfiguration(PubSubBinderTestConfig.class) | ||
| .withPropertyValues("spring.cloud.stream.bindings.input.group=testGroup") |
There was a problem hiding this comment.
This test relies on a lot of internal Spring Cloud Stream implementation details. Would it be easier to retrieve the adapter/message source by name? Or customize ACK method and verify that instead of verifying the name?
There was a problem hiding this comment.
It might be possible, but I simply followed the test design for Kafka binder.
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
`ConsumerEndpointCustomizer<PubSubInboundChannelAdapter>` and `ProducerMessageHandlerCustomizer<PubSubMessageHandler>` user beans can now be provided to customize the Pub/Sub binder. Fixes: GoogleCloudPlatform#182.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsumerEndpointCustomizer<PubSubInboundChannelAdapter>andProducerMessageHandlerCustomizer<PubSubMessageHandler>user beans can now be provided to customize the Pub/Sub binder.Fixes: #182.