fix: use core id provider as backup provider #1798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
requested changes
May 5, 2023
| @Test | ||
| void testSecretManagerWithoutProjectId() { | ||
| contextRunner.run( | ||
| ctx -> assertThat(ctx.getBean(GcpSecretManagerProperties.class) |
There was a problem hiding this comment.
This is not testing GcpSecretManagerAutoConfiguration.
There was a problem hiding this comment.
There's not easy to test the project id as GcpSecretManagerAutoConfiguration doesn't expose a getter method.
There was a problem hiding this comment.
I added a getter method in SecretManagerTemplate so that project id can be tested.
| @Test | ||
| void testSecretManagerWithProjectId() { | ||
| contextRunner | ||
| .withPropertyValues("spring.cloud.gcp.secretmanager.project-id=testProject") |
There was a problem hiding this comment.
We need a test with spring.cloud.gcp.project-id=testGlobalProject.
meltsufin
approved these changes
May 5, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1793.