Skip to content

Commit 0902b6e

Browse files
committed
Merge branch 'add-spanner-proto-columns-samples' of github.com:googlecloudplatform/php-docs-samples into add-spanner-proto-columns-samples
2 parents 33c08b1 + 72449d7 commit 0902b6e

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

.github/workflows/lint.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
php-version: '8.2'
2929
- name: Get changed files
3030
id: changedFiles
31-
uses: tj-actions/changed-files@v44
31+
uses: tj-actions/changed-files@v46
3232
- uses: jwalton/gh-find-current-pr@v1
3333
id: findPr
3434
with:

CODEOWNERS

+1-5
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
/cloud_sql/**/*.php @GoogleCloudPlatform/infra-db-sdk @GoogleCloudPlatform/php-samples-reviewers
2323
/datastore/**/*.php @GoogleCloudPlatform/cloud-native-db-dpes @GoogleCloudPlatform/php-samples-reviewers
2424
/firestore/**/*.php @GoogleCloudPlatform/cloud-native-db-dpes @GoogleCloudPlatform/php-samples-reviewers
25-
/storage/ @GoogleCloudPlatform/cloud-storage-dpe @GoogleCloudPlatform/php-samples-reviewers
25+
/storage/ @GoogleCloudPlatform/gcs-sdk-team @GoogleCloudPlatform/php-samples-reviewers
2626
/spanner/ @GoogleCloudPlatform/api-spanner @GoogleCloudPlatform/php-samples-reviewers
2727
/secretmanager/ @GoogleCloudPlatform/php-samples-reviewers @GoogleCloudPlatform/cloud-secrets-team
2828

@@ -33,10 +33,6 @@
3333
/run/ @GoogleCloudPlatform/torus-dpe @GoogleCloudPlatform/php-samples-reviewers
3434
/eventarc/ @GoogleCloudPlatform/torus-dpe @GoogleCloudPlatform/php-samples-reviewers
3535

36-
# Functions samples owned by the Firebase team
37-
38-
/functions/firebase_analytics @schandel
39-
4036
# DLP samples owned by DLP team
4137

4238
/dlp/ @GoogleCloudPlatform/googleapis-dlp

spanner/src/pg_create_database.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
namespace Google\Cloud\Samples\Spanner;
2525

26-
// [START spanner_create_postgres_database]
26+
// [START spanner_postgresql_create_database]
2727
use Google\Cloud\Spanner\Admin\Database\V1\Client\DatabaseAdminClient;
2828
use Google\Cloud\Spanner\Admin\Database\V1\CreateDatabaseRequest;
2929
use Google\Cloud\Spanner\Admin\Database\V1\DatabaseDialect;
@@ -86,7 +86,7 @@ function pg_create_database(string $projectId, string $instanceId, string $datab
8686
printf('Created database %s with dialect %s on instance %s' . PHP_EOL,
8787
$databaseId, $dialect, $instanceId);
8888
}
89-
// [END spanner_create_postgres_database]
89+
// [END spanner_postgresql_create_database]
9090

9191
// The following 2 lines are only needed to run the samples
9292
require_once __DIR__ . '/../../testing/sample_helpers.php';

0 commit comments

Comments
 (0)