feat: add cdn signed url sample #4011
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @zabdalimov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds a new sample for generating signed URLs for Google Cloud CDN. It includes the core signing logic in signurl.js, a test case for the signing function in signurl.test.js, a package.json file to manage dependencies and testing, and a GitHub Actions workflow file (cdn-signed-urls.yaml) to automate testing. The workflow is also added to the list of workflows in .github/workflows/utils/workflows.json.
Highlights
- New Functionality: Introduces a
signUrlfunction to generate signed URLs for Google Cloud CDN, enhancing security for CDN resources. - Testing: Includes a test case (
signurl.test.js) to ensure thesignUrlfunction generates correct signed URLs with the expected parameters. - Automation: Adds a GitHub Actions workflow (
cdn-signed-urls.yaml) to automate testing of the CDN signed URLs sample.
Changelog
Click here to see the changelog
- .github/workflows/cdn-signed-urls.yaml
- Created a new workflow file to automate testing for the CDN signed URLs sample.
- Configured the workflow to run on pushes to the main branch and pull requests targeting the
cdn/signed-urlsdirectory. - Added jobs for testing and flaky bot analysis.
- .github/workflows/utils/workflows.json
- Added
cdn/signed-urlsto the list of workflows to be tested.
- Added
- cdn/signed-urls/package.json
- Created a
package.jsonfile to manage dependencies (mocha) and define test scripts. - Specified the node engine version as >=16.0.0.
- Created a
- cdn/signed-urls/signurl.js
- Implemented the
signUrlfunction to generate signed URLs for Google Cloud CDN. - The function takes the URL, key name, key value, and expiration date as input.
- It uses the crypto module to generate the signature.
- Implemented the
- cdn/signed-urls/test/signurl.test.js
- Created a test file for the
signUrlfunction. - The test case verifies that the generated URL contains the correct parameters (KeyName, Expires, Signature).
- Created a test file for the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What does CDN stand for?
Click here for the answer
Content Delivery Network
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces a new sample for generating signed URLs for Google Cloud CDN. The code includes a function to sign URLs, a test case, and necessary configurations. Overall, the code is well-structured and easy to understand.
Merge Readiness
The code appears to be in good shape for merging. The functionality is well-tested, and the code is clear and concise. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
Description
Fixes #2437
I'm not associated with Google, but there was an existing issue that covers what I'm trying to achieve, so I didn't create a new one.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.