Skip to content

Commit dbaf7b5

Browse files
jmdobryjmdobry
authored
Use a real Error in tests. (#192)
1 parent 3607c6b commit dbaf7b5

File tree

12 files changed

+62
-62
lines changed

12 files changed

+62
-62
lines changed

‎bigquery/test/queries.test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ describe('bigquery:query', function () {
8585
});
8686

8787
it('should handle error', function () {
88-
var error = Error('syncQueryError');
88+
var error = new Error('error');
8989
var example = getSample();
9090
example.mocks.bigquery.query = sinon.stub().callsArgWith(1, error);
9191
example.program.syncQuery(query, function (err, data) {
@@ -121,7 +121,7 @@ describe('bigquery:query', function () {
121121
});
122122

123123
it('should handle error', function () {
124-
var error = Error('asyncQueryError');
124+
var error = new Error('error');
125125
var example = getSample();
126126
example.mocks.bigquery.startQuery = sinon.stub().callsArgWith(1, error);
127127
example.program.asyncQuery(query, function (err, job) {
@@ -193,7 +193,7 @@ describe('bigquery:query', function () {
193193
});
194194

195195
it('should handle error', function () {
196-
var error = Error('asyncPollError');
196+
var error = new Error('error');
197197
var example = getSample();
198198
example.mocks.job.getQueryResults = sinon.stub().callsArgWith(0, error);
199199
example.program.asyncPoll(example.jobId, function (err, rows) {

‎bigquery/test/tables.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ describe('bigquery:tables', function () {
278278
});
279279

280280
it('should handle export error', function () {
281-
var error = new Error('exportTableToGCSError');
281+
var error = new Error('error');
282282
var example = getSample();
283283
var callback = sinon.stub();
284284
example.mocks.table.export.yields(error);

‎logging/test/logs.test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ describe('logging:entries', function () {
7474
});
7575

7676
it('should handle error', function () {
77-
var error = 'error';
77+
var error = new Error('error');
7878
var sample = getSample();
7979
var callback = sinon.stub();
8080
sample.mocks.logging.getEntries = sinon.stub().callsArgWith(1, error);
@@ -107,7 +107,7 @@ describe('logging:entries', function () {
107107
});
108108

109109
it('should handle error', function () {
110-
var error = 'error';
110+
var error = new Error('error');
111111
var sample = getSample();
112112
var callback = sinon.stub();
113113
sample.mocks.log.write = sinon.stub().callsArgWith(1, error);
@@ -137,7 +137,7 @@ describe('logging:entries', function () {
137137
});
138138

139139
it('should handle error', function () {
140-
var error = 'error';
140+
var error = new Error('error');
141141
var sample = getSample();
142142
var callback = sinon.stub();
143143
sample.mocks.log.delete = sinon.stub().callsArgWith(0, error);

‎logging/test/sinks.test.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ describe('logging:sinks', function () {
149149
});
150150

151151
it('should handle error', function () {
152-
var error = 'error';
152+
var error = new Error('error');
153153
var sample = getSample();
154154
var callback = sinon.stub();
155155
sample.mocks.sink.create = sinon.stub().callsArgWith(1, error);
@@ -180,7 +180,7 @@ describe('logging:sinks', function () {
180180
});
181181

182182
it('should handle error', function () {
183-
var error = 'error';
183+
var error = new Error('error');
184184
var sample = getSample();
185185
var callback = sinon.stub();
186186
sample.mocks.sink.getMetadata = sinon.stub().callsArgWith(0, error);
@@ -211,7 +211,7 @@ describe('logging:sinks', function () {
211211
});
212212

213213
it('should handle error', function () {
214-
var error = 'error';
214+
var error = new Error('error');
215215
var sample = getSample();
216216
var callback = sinon.stub();
217217
sample.mocks.logging.getSinks = sinon.stub().callsArgWith(0, error);
@@ -248,7 +248,7 @@ describe('logging:sinks', function () {
248248
});
249249

250250
it('should handle error', function () {
251-
var error = 'error';
251+
var error = new Error('error');
252252
var sample = getSample();
253253
var callback = sinon.stub();
254254
sample.mocks.sink.setMetadata = sinon.stub().callsArgWith(1, error);
@@ -278,7 +278,7 @@ describe('logging:sinks', function () {
278278
});
279279

280280
it('should handle error', function () {
281-
var error = 'error';
281+
var error = new Error('error');
282282
var sample = getSample();
283283
var callback = sinon.stub();
284284
sample.mocks.sink.delete = sinon.stub().callsArgWith(0, error);

‎pubsub/test/iam.test.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ describe('pubsub:iam', function () {
7272
});
7373
it('should handle error', function () {
7474
var sample = getSample();
75-
var error = 'error';
76-
sample.mocks.topic.iam.getPolicy.callsArgWith(0, new Error(error));
75+
var error = new Error('error');
76+
sample.mocks.topic.iam.getPolicy.callsArgWith(0, error);
7777
sample.program.getTopicPolicy(topicName, function (err) {
7878
assert(err);
7979
assert(err.message === 'error');
@@ -100,8 +100,8 @@ describe('pubsub:iam', function () {
100100
});
101101
it('should handle error', function () {
102102
var sample = getSample();
103-
var error = 'error';
104-
sample.mocks.subscription.iam.getPolicy.callsArgWith(0, new Error(error));
103+
var error = new Error('error');
104+
sample.mocks.subscription.iam.getPolicy.callsArgWith(0, error);
105105
sample.program.getSubscriptionPolicy(subscriptionName, function (err) {
106106
assert(err);
107107
assert(err.message === 'error');
@@ -128,8 +128,8 @@ describe('pubsub:iam', function () {
128128
});
129129
it('should handle error', function () {
130130
var sample = getSample();
131-
var error = 'error';
132-
sample.mocks.topic.iam.setPolicy.callsArgWith(1, new Error(error));
131+
var error = new Error('error');
132+
sample.mocks.topic.iam.setPolicy.callsArgWith(1, error);
133133
sample.program.setTopicPolicy(topicName, function (err) {
134134
assert(err);
135135
assert(err.message === 'error');
@@ -156,8 +156,8 @@ describe('pubsub:iam', function () {
156156
});
157157
it('should handle error', function () {
158158
var sample = getSample();
159-
var error = 'error';
160-
sample.mocks.subscription.iam.setPolicy.callsArgWith(1, new Error(error));
159+
var error = new Error('error');
160+
sample.mocks.subscription.iam.setPolicy.callsArgWith(1, error);
161161
sample.program.setSubscriptionPolicy(subscriptionName, function (err) {
162162
assert(err);
163163
assert(err.message === 'error');
@@ -184,8 +184,8 @@ describe('pubsub:iam', function () {
184184
});
185185
it('should handle error', function () {
186186
var sample = getSample();
187-
var error = 'error';
188-
sample.mocks.topic.iam.testPermissions.callsArgWith(1, new Error(error));
187+
var error = new Error('error');
188+
sample.mocks.topic.iam.testPermissions.callsArgWith(1, error);
189189
sample.program.testTopicPermissions(topicName, function (err, permissions) {
190190
assert(err);
191191
assert(err.message === 'error');
@@ -213,8 +213,8 @@ describe('pubsub:iam', function () {
213213
});
214214
it('should handle error', function () {
215215
var sample = getSample();
216-
var error = 'error';
217-
sample.mocks.subscription.iam.testPermissions.callsArgWith(1, new Error(error));
216+
var error = new Error('error');
217+
sample.mocks.subscription.iam.testPermissions.callsArgWith(1, error);
218218
sample.program.testSubscriptionPermissions(subscriptionName, function (err, permissions) {
219219
assert(err);
220220
assert(err.message === 'error');

‎pubsub/test/subscriptions.test.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ describe('pubsub:subscriptions', function () {
9191
});
9292
it('should handle error', function () {
9393
var sample = getSample();
94-
var error = 'error';
95-
sample.mocks.pubsub.subscribe.callsArgWith(3, new Error(error));
94+
var error = new Error('error');
95+
sample.mocks.pubsub.subscribe.callsArgWith(3, error);
9696
sample.program.createSubscription(topicName, subscriptionName, function (err) {
9797
assert(err);
9898
assert(err.message === 'error');
@@ -118,8 +118,8 @@ describe('pubsub:subscriptions', function () {
118118
});
119119
it('should handle error', function () {
120120
var sample = getSample();
121-
var error = 'error';
122-
sample.mocks.subscription.delete.callsArgWith(0, new Error(error));
121+
var error = new Error('error');
122+
sample.mocks.subscription.delete.callsArgWith(0, error);
123123
sample.program.deleteSubscription(subscriptionName, function (err) {
124124
assert(err);
125125
assert(err.message === 'error');
@@ -146,8 +146,8 @@ describe('pubsub:subscriptions', function () {
146146
});
147147
it('should handle error', function () {
148148
var sample = getSample();
149-
var error = 'error';
150-
sample.mocks.pubsub.getSubscriptions.callsArgWith(1, new Error(error));
149+
var error = new Error('error');
150+
sample.mocks.pubsub.getSubscriptions.callsArgWith(1, error);
151151
sample.program.listSubscriptions(undefined, function (err, subscriptions) {
152152
assert(err);
153153
assert(err.message === 'error');
@@ -176,8 +176,8 @@ describe('pubsub:subscriptions', function () {
176176
});
177177
it('should handle pull error', function () {
178178
var sample = getSample();
179-
var error = 'error';
180-
sample.mocks.subscription.pull.callsArgWith(1, new Error(error));
179+
var error = new Error('error');
180+
sample.mocks.subscription.pull.callsArgWith(1, error);
181181
sample.program.pullMessages(subscriptionName, function (err, messages) {
182182
assert(err);
183183
assert(err.message === 'error');
@@ -186,8 +186,8 @@ describe('pubsub:subscriptions', function () {
186186
});
187187
it('should handle ack error', function () {
188188
var sample = getSample();
189-
var error = 'error';
190-
sample.mocks.subscription.ack.callsArgWith(1, new Error(error));
189+
var error = new Error('error');
190+
sample.mocks.subscription.ack.callsArgWith(1, error);
191191
sample.program.pullMessages(subscriptionName, function (err) {
192192
assert(err);
193193
assert(err.message === 'error');

‎pubsub/test/topics.test.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ describe('pubsub:topics', function () {
6767
});
6868
it('should handle error', function () {
6969
var sample = getSample();
70-
var error = 'error';
71-
sample.mocks.topic.get.callsArgWith(1, new Error(error));
70+
var error = new Error('error');
71+
sample.mocks.topic.get.callsArgWith(1, error);
7272
sample.program.createTopic(topicName, function (err) {
7373
assert(err);
7474
assert(err.message === 'error');
@@ -94,8 +94,8 @@ describe('pubsub:topics', function () {
9494
});
9595
it('should handle error', function () {
9696
var sample = getSample();
97-
var error = 'error';
98-
sample.mocks.topic.delete.callsArgWith(0, new Error(error));
97+
var error = new Error('error');
98+
sample.mocks.topic.delete.callsArgWith(0, error);
9999
sample.program.deleteTopic(topicName, function (err) {
100100
assert(err);
101101
assert(err.message === 'error');
@@ -138,8 +138,8 @@ describe('pubsub:topics', function () {
138138
});
139139
it('should handle error', function () {
140140
var sample = getSample();
141-
var error = 'error';
142-
sample.mocks.topic.publish.callsArgWith(1, new Error(error));
141+
var error = new Error('error');
142+
sample.mocks.topic.publish.callsArgWith(1, error);
143143
sample.program.publishMessage(topicName, '{"data":"hello world"}', function (err, messageIds) {
144144
assert(err);
145145
assert(err.message === 'error');
@@ -159,8 +159,8 @@ describe('pubsub:topics', function () {
159159
});
160160
it('should handle error', function () {
161161
var sample = getSample();
162-
var error = 'error';
163-
sample.mocks.pubsub.getTopics.callsArgWith(0, new Error(error));
162+
var error = new Error('error');
163+
sample.mocks.pubsub.getTopics.callsArgWith(0, error);
164164
sample.program.listTopics(function (err, topics) {
165165
assert(err);
166166
assert(err.message === 'error');

‎storage/test/acl.test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ describe('storage:acl', function () {
140140
});
141141

142142
it('should handle error', function () {
143-
var error = 'error';
143+
var error = new Error('error');
144144
var sample = getSample();
145145
var callback = sinon.stub();
146146
sample.mocks.bucket.acl.add = sinon.stub().callsArgWith(1, error);
@@ -263,7 +263,7 @@ describe('storage:acl', function () {
263263
});
264264

265265
it('should handle error', function () {
266-
var error = 'error';
266+
var error = new Error('error');
267267
var sample = getSample();
268268
var callback = sinon.stub();
269269
var options = {
@@ -346,7 +346,7 @@ describe('storage:acl', function () {
346346
});
347347

348348
it('should handle error', function () {
349-
var error = 'error';
349+
var error = new Error('error');
350350
var sample = getSample();
351351
var callback = sinon.stub();
352352
var options = {

‎storage/test/buckets.test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe('storage:buckets', function () {
6565
});
6666

6767
it('should handle error', function () {
68-
var error = 'error';
68+
var error = new Error('error');
6969
var sample = getSample();
7070
var callback = sinon.stub();
7171
sample.mocks.bucket.create = sinon.stub().callsArgWith(0, error);
@@ -96,7 +96,7 @@ describe('storage:buckets', function () {
9696
});
9797

9898
it('should handle error', function () {
99-
var error = 'error';
99+
var error = new Error('error');
100100
var sample = getSample();
101101
var callback = sinon.stub();
102102
sample.mocks.storage.getBuckets = sinon.stub().callsArgWith(0, error);
@@ -128,7 +128,7 @@ describe('storage:buckets', function () {
128128
});
129129

130130
it('should handle error', function () {
131-
var error = 'error';
131+
var error = new Error('error');
132132
var sample = getSample();
133133
var callback = sinon.stub();
134134
sample.mocks.bucket.delete = sinon.stub().callsArgWith(0, error);

‎storage/test/encryption.test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ describe('storage:encryption', function () {
9090
});
9191

9292
it('should handle error', function () {
93-
var error = 'error';
93+
var error = new Error('error');
9494
var sample = getSample();
9595
var callback = sinon.stub();
9696
var options = {
@@ -135,7 +135,7 @@ describe('storage:encryption', function () {
135135
});
136136

137137
it('should handle error', function () {
138-
var error = 'error';
138+
var error = new Error('error');
139139
var sample = getSample();
140140
var callback = sinon.stub();
141141
var options = {

0 commit comments

Comments
 (0)