Skip to content

Commit d3bc744

Browse files
gcf-owl-bot[bot]alexander-fenster
authored andcommitted
fix: allow passing gax instance to client constructor (#612)
* fix: better support for fallback mode PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: accept google-gax instance as a parameter Please see the documentation of the client constructor for details. PiperOrigin-RevId: 470332808 Source-Link: googleapis/googleapis@d4a2367 Source-Link: googleapis/googleapis-gen@e97a1ac Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: use _gaxModule when accessing gax for bundling PiperOrigin-RevId: 470911839 Source-Link: googleapis/googleapis@3527566 Source-Link: googleapis/googleapis-gen@f16a1d2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * test: do not fail if cleanup fails Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Alexander Fenster <[email protected]>
1 parent f40bb62 commit d3bc744

File tree

1 file changed

+18
-14
lines changed

1 file changed

+18
-14
lines changed

dataproc/system-test/quickstart.test.js

+18-14
Original file line numberDiff line numberDiff line change
@@ -66,23 +66,27 @@ describe('execute the quickstart', () => {
6666
});
6767

6868
afterEach(async () => {
69-
await storage.bucket(bucketName).file(jobFileName).delete();
70-
await storage.bucket(bucketName).delete();
69+
try {
70+
await storage.bucket(bucketName).file(jobFileName).delete();
71+
await storage.bucket(bucketName).delete();
7172

72-
const [clusters] = await clusterClient.listClusters({
73-
projectId: projectId,
74-
region: region,
75-
});
73+
const [clusters] = await clusterClient.listClusters({
74+
projectId: projectId,
75+
region: region,
76+
});
7677

77-
for (const cluster of clusters) {
78-
if (cluster.clusterName === clusterName) {
79-
await clusterClient.deleteCluster({
80-
projectId: projectId,
81-
region: region,
82-
clusterName: clusterName,
83-
});
84-
break;
78+
for (const cluster of clusters) {
79+
if (cluster.clusterName === clusterName) {
80+
await clusterClient.deleteCluster({
81+
projectId: projectId,
82+
region: region,
83+
clusterName: clusterName,
84+
});
85+
break;
86+
}
8587
}
88+
} catch (err) {
89+
console.error('Cannot clean up resources:', err);
8690
}
8791
});
8892
});

0 commit comments

Comments
 (0)