Skip to content

Commit 56fa69a

Browse files
refactor: use execSync for tests (#195)
1 parent 7327dbb commit 56fa69a

File tree

4 files changed

+14
-16
lines changed

4 files changed

+14
-16
lines changed

cloud-tasks/.eslintrc.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
---
22
rules:
33
no-console: off
4+
node/no-missing-require: off

cloud-tasks/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"node": ">=8"
99
},
1010
"scripts": {
11-
"test": "mocha system-test"
11+
"test": "mocha"
1212
},
1313
"dependencies": {
1414
"@google-cloud/tasks": "^0.5.0",
@@ -17,7 +17,7 @@
1717
"yargs": "^13.0.0"
1818
},
1919
"devDependencies": {
20-
"execa": "^1.0.0",
20+
"chai": "^4.2.0",
2121
"mocha": "^6.0.0",
2222
"uuid": "^3.3.2"
2323
}

cloud-tasks/system-test/test.samples.js renamed to cloud-tasks/test/test.samples.js

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,31 +14,28 @@
1414

1515
'use strict';
1616

17-
const path = require('path');
18-
const assert = require('assert');
19-
const execa = require('execa');
17+
const {assert} = require('chai');
18+
const {execSync} = require('child_process');
2019
const uuid = require('uuid');
2120

2221
const PROJECT_ID = process.env.GCLOUD_PROJECT;
2322
const queueName = `gcloud-${uuid.v4().split('-')[0]}`;
24-
const cwd = path.join(__dirname, '..');
25-
const exec = cmd => execa.shell(cmd, {cwd});
2623

2724
describe('Cloud Task Sample Tests', () => {
28-
it('should create a queue', async () => {
29-
const {stdout} = await exec(`node createQueue ${PROJECT_ID} ${queueName}`);
30-
assert.ok(stdout.includes('Created queue'));
25+
it('should create a queue', () => {
26+
const stdout = execSync(`node createQueue ${PROJECT_ID} ${queueName}`);
27+
assert.match(stdout, /Created queue/);
3128
});
3229

33-
it('should create a task', async () => {
34-
const {stdout} = await exec(
30+
it('should create a task', () => {
31+
const stdout = execSync(
3532
`node createTask --project=${PROJECT_ID} --location=us-central1 --queue=${queueName}`
3633
);
37-
assert.ok(stdout.includes('Created task'));
34+
assert.match(stdout, /Created task/);
3835
});
3936

40-
it('should delete a queue', async () => {
41-
const {stdout} = await exec(`node deleteQueue ${PROJECT_ID} ${queueName}`);
42-
assert.ok(stdout.includes('Deleted queue'));
37+
it('should delete a queue', () => {
38+
const stdout = execSync(`node deleteQueue ${PROJECT_ID} ${queueName}`);
39+
assert.match(stdout, /Deleted queue/);
4340
});
4441
});

0 commit comments

Comments
 (0)