Skip to content

Commit a60498c

Browse files
authored
Merge pull request #505 from GoogleCloudPlatform/fix-endpoints-discovery
Temporary fix for Endpoints Frameworks v2.0 discovery doc sample
2 parents de8f004 + 532ecf3 commit a60498c

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

appengine/endpoints-frameworks-v2/discovery/README.md

+8
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,13 @@ provided [here][9].
9696
9797
`gradle appengineDeploy`
9898
99+
## Known issues
100+
101+
There's a [bug][13] where `<version>1</version>` is required in the
102+
[appengine-web.xml](src/main/webapp/WEB-INF/appengine-web.xml) to run
103+
this sample locally. This will become optional in the near future.
104+
105+
99106
[1]: https://cloud.google.com/appengine/docs/java/
100107
[2]: http://java.com/en/
101108
[3]: https://cloud.google.com/appengine/docs/java/endpoints/
@@ -108,3 +115,4 @@ provided [here][9].
108115
[10]: https://github.com/GoogleCloudPlatform/endpoints-framework-maven-plugin
109116
[11]: https://github.com/GoogleCloudPlatform/endpoints-framework-gradle-plugin
110117
[12]: https://cloud.google.com/endpoints/docs/authenticating-users-frameworks
118+
[13]: https://github.com/cloudendpoints/endpoints-java/issues/43

appengine/endpoints-frameworks-v2/discovery/build.gradle

-3
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ buildscript { // Configuration for building
2424
}
2525

2626
repositories { // repositories for Jar's you access in your code
27-
maven {
28-
url 'https://oss.sonatype.org/content/repositories/snapshots' // SNAPSHOT Repository (if needed)
29-
}
3027
mavenCentral()
3128
jcenter()
3229
}

appengine/endpoints-frameworks-v2/discovery/src/main/webapp/WEB-INF/appengine-web.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1515
See the License for the specific language governing permissions and
1616
limitations under the License.
1717
-->
18-
<threadsafe>true</threadsafe>
19-
18+
<threadsafe>true</threadsafe>
19+
<version>1</version>
2020
<system-properties>
2121
<property name="java.util.logging.config.file" value="WEB-INF/logging.properties"/>
2222
</system-properties>

0 commit comments

Comments
 (0)