Skip to content

Commit 80283cb

Browse files
nnegreychingor13
authored andcommitted
samples: vision: update product search tests (#2378)
* vision: update product search tests * update other broken tests
1 parent a61d4d4 commit 80283cb

File tree

3 files changed

+18
-29
lines changed

3 files changed

+18
-29
lines changed

vision/snippets/src/test/java/com/example/vision/ProductSetManagementIT.java

+8-23
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@
1919
import static com.google.common.truth.Truth.assertThat;
2020

2121
import java.io.ByteArrayOutputStream;
22-
import java.io.IOException;
2322
import java.io.PrintStream;
23+
import java.util.UUID;
24+
2425
import org.junit.After;
2526
import org.junit.Before;
2627
import org.junit.Test;
@@ -33,52 +34,36 @@
3334
public class ProductSetManagementIT {
3435
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
3536
private static final String COMPUTE_REGION = "us-west1";
36-
private static final String PRODUCT_SET_ID = "fake_prodt_set_id_for_testing";
37+
private static final String PRODUCT_SET_ID =
38+
String.format("test_%s", UUID.randomUUID().toString());
3739
private static final String PRODUCT_SET_DISPLAY_NAME =
38-
"fake_prodt_set_display_name_for_testing";
40+
String.format("test_%s", UUID.randomUUID().toString());
3941
private ByteArrayOutputStream bout;
4042
private PrintStream out;
4143

4244
@Before
43-
public void setUp() throws IOException {
45+
public void setUp() {
4446
bout = new ByteArrayOutputStream();
4547
out = new PrintStream(bout);
4648
System.setOut(out);
4749
}
4850

4951
@After
5052
public void tearDown() {
51-
5253
System.setOut(null);
5354
}
5455

5556
@Test
5657
public void testCreateDeleteProductSet() throws Exception {
57-
// Act
58-
ProductSetManagement.listProductSets(PROJECT_ID, COMPUTE_REGION);
59-
60-
// Assert
61-
String got = bout.toString();
62-
assertThat(got).doesNotContain(PRODUCT_SET_ID);
63-
64-
bout.reset();
65-
66-
// Act
6758
ProductSetManagement.createProductSet(
68-
PROJECT_ID, COMPUTE_REGION, PRODUCT_SET_ID, PRODUCT_SET_DISPLAY_NAME);
69-
ProductSetManagement.listProductSets(PROJECT_ID, COMPUTE_REGION);
70-
71-
// Assert
72-
got = bout.toString();
59+
PROJECT_ID, COMPUTE_REGION, PRODUCT_SET_ID, PRODUCT_SET_DISPLAY_NAME);
60+
String got = bout.toString();
7361
assertThat(got).contains(PRODUCT_SET_ID);
7462

7563
bout.reset();
7664

77-
// Act
7865
ProductSetManagement.deleteProductSet(PROJECT_ID, COMPUTE_REGION, PRODUCT_SET_ID);
7966
ProductSetManagement.listProductSets(PROJECT_ID, COMPUTE_REGION);
80-
81-
// Assert
8267
got = bout.toString();
8368
assertThat(got).doesNotContain(PRODUCT_SET_ID);
8469
}

vision/snippets/src/test/java/vision/snippets/ProductInProductSetManagementTests.java

+6-4
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,13 @@ public class ProductInProductSetManagementTests {
3535
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
3636
private static final String COMPUTE_REGION = "us-west1";
3737
private static final String PRODUCT_SET_DISPLAY_NAME =
38-
"fake_pdt_set_display_name_for_testing";
39-
private static final String PRODUCT_SET_ID = "fake_pdt_set_id_for_testing" + UUID.randomUUID();
40-
private static final String PRODUCT_DISPLAY_NAME = "fake_pdt_display_name_for_testing";
38+
String.format("test_%s", UUID.randomUUID().toString());
39+
private static final String PRODUCT_SET_ID =
40+
String.format("test_%s", UUID.randomUUID().toString());
41+
private static final String PRODUCT_DISPLAY_NAME =
42+
String.format("test_%s", UUID.randomUUID().toString());
4143
private static final String PRODUCT_CATEGORY = "apparel";
42-
private static final String PRODUCT_ID = "fake_pdt_id_for_testing";
44+
private static final String PRODUCT_ID = String.format("test_%s", UUID.randomUUID().toString());
4345
private ByteArrayOutputStream bout;
4446
private PrintStream out;
4547

vision/snippets/src/test/java/vision/snippets/ProductManagementTests.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import java.io.ByteArrayOutputStream;
2424
import java.io.IOException;
2525
import java.io.PrintStream;
26+
import java.util.UUID;
2627

2728
import org.junit.After;
2829
import org.junit.Before;
@@ -35,9 +36,10 @@ public class ProductManagementTests {
3536

3637
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
3738
private static final String COMPUTE_REGION = "us-west1";
38-
private static final String PRODUCT_DISPLAY_NAME = "fake_prod_display_name_for_testing";
39+
private static final String PRODUCT_DISPLAY_NAME =
40+
String.format("test_%s", UUID.randomUUID().toString());
3941
private static final String PRODUCT_CATEGORY = "homegoods";
40-
private static final String PRODUCT_ID = "fake_prod_id_for_testing";
42+
private static final String PRODUCT_ID = String.format("test_%s", UUID.randomUUID().toString());
4143
private ByteArrayOutputStream bout;
4244
private PrintStream out;
4345

0 commit comments

Comments
 (0)