Skip to content

Commit 6b22d4d

Browse files
authored
Use the socketFactory everywhere (#682)
1. No longer use the Google Connector/j
1 parent 1f2d446 commit 6b22d4d

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

appengine-java8/cloudsql/pom.xml

+4-3
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,15 @@
6969
</dependency>
7070

7171
<!-- [START dependencies] -->
72-
<dependency> <!-- ONLY USED LOCALY -->
72+
<dependency>
7373
<groupId>mysql</groupId>
7474
<artifactId>mysql-connector-java</artifactId>
75-
<version>5.1.40</version> <!-- v5.x.x is Java 7, v6.x.x is Java 8 -->
75+
<version>5.1.40</version> <!-- v5.x.x is for production, v6.x.x EAP X DevAPI and Java 8 -->
76+
<!--<version>6.0.6</version>-->
7677
</dependency>
7778
<dependency>
7879
<groupId>com.google.cloud.sql</groupId>
79-
<artifactId>mysql-socket-factory</artifactId>
80+
<artifactId>mysql-socket-factory</artifactId> <!-- mysql-socket-factory-connector-j-6 -->
8081
<version>1.0.2</version>
8182
</dependency>
8283
<!-- [END dependencies] -->

appengine-java8/cloudsql/src/main/webapp/WEB-INF/appengine-web.xml

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
<threadsafe>true</threadsafe>
1717
<runtime>java8</runtime>
1818

19-
<use-google-connector-j>true</use-google-connector-j>
19+
<!-- <use-google-connector-j>true</use-google-connector-j> NO LONGER REQUIRED -->
2020
<system-properties>
21-
<property name="ae-cloudsql.cloudsql-database-url" value="jdbc:google:mysql://${INSTANCE_CONNECTION_NAME}/${database}?user=${user}&amp;password=${password}" />
22-
<property name="ae-cloudsql.local-database-url" value="jdbc:mysql://google/${database}?cloudSqlInstance=${INSTANCE_CONNECTION_NAME}&amp;socketFactory=com.google.cloud.sql.mysql.SocketFactory&amp;user=${user}&amp;password=${password}&amp;useSSL=false" />
21+
<property name="ae-cloudsql.cloudsql-database-url" value="jdbc:mysql://google/${database}?useSSL=false&amp;cloudSqlInstance=${INSTANCE_CONNECTION_NAME}&amp;socketFactory=com.google.cloud.sql.mysql.SocketFactory&amp;user=${user}&amp;password=${password}" />
22+
<property name="ae-cloudsql.local-database-url" value="jdbc:mysql://google/${database}?useSSL=false&amp;cloudSqlInstance=${INSTANCE_CONNECTION_NAME}&amp;socketFactory=com.google.cloud.sql.mysql.SocketFactory&amp;user=${user}&amp;password=${password}" />
2323
</system-properties>
2424
</appengine-web-app>
2525
<!-- [END config] -->

0 commit comments

Comments
 (0)