Skip to content

Commit 66d8aca

Browse files
munkhuushmglgcf-owl-bot[bot]averikitsch
authored andcommitted
chore: fix batch test (#585)
* chore: fix batch test * fixed nit * 🦉 Updates from OwlBot * Update samples/snippets/src/test/java/com/example/translate/BatchTranslateTextTests.java Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Averi Kitsch <[email protected]>
1 parent f0257b1 commit 66d8aca

File tree

4 files changed

+28
-12
lines changed

4 files changed

+28
-12
lines changed

translate/snippets/src/test/java/com/example/translate/BatchTranslateTextTests.java

+7-3
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,12 @@
4242
@RunWith(JUnit4.class)
4343
@SuppressWarnings("checkstyle:abbreviationaswordinname")
4444
public class BatchTranslateTextTests {
45+
4546
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
4647
private static final String INPUT_URI = "gs://cloud-samples-data/translation/text.txt";
47-
private static final String PREFIX = "BATCH_TRANSLATION_OUTPUT/";
48-
private static final String OUTPUT_URI =
49-
String.format("gs://%s/%s%s/", PROJECT_ID, PREFIX, UUID.randomUUID());
48+
private static final String PREFIX =
49+
String.format("translation-%s/%s", UUID.randomUUID(), "BATCH_TRANSLATION_OUTPUT/");
50+
private static final String OUTPUT_URI = String.format("gs://%s/%s", PROJECT_ID, PREFIX);
5051

5152
private ByteArrayOutputStream bout;
5253
private PrintStream out;
@@ -97,6 +98,9 @@ public void setUp() {
9798
out = new PrintStream(bout);
9899
originalPrintStream = System.out;
99100
System.setOut(out);
101+
102+
// clean up bucket before the use to prevent concurrency issue.
103+
cleanUpBucket();
100104
}
101105

102106
@After

translate/snippets/src/test/java/com/example/translate/BatchTranslateTextWithGlossaryAndModelTests.java

+7-3
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,15 @@
4242
@RunWith(JUnit4.class)
4343
@SuppressWarnings("checkstyle:abbreviationaswordinname")
4444
public class BatchTranslateTextWithGlossaryAndModelTests {
45+
4546
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
4647
private static final String INPUT_URI =
4748
"gs://cloud-samples-data/translation/text_with_custom_model_and_glossary.txt";
4849
private static final String GLOSSARY_ID = "DO_NOT_DELETE_TEST_GLOSSARY";
4950
private static final String MODEL_ID = "TRL3645318651705294848";
50-
private static final String PREFIX = "BATCH_TRANSLATION_WITH_MODEL_OUTPUT/";
51-
private static final String OUTPUT_URI =
52-
String.format("gs://%s/%s%s/", PROJECT_ID, PREFIX, UUID.randomUUID());
51+
private static final String PREFIX =
52+
String.format("translation-%s/%s", UUID.randomUUID(), "BATCH_TRANSLATION_WITH_MODEL_OUTPUT/");
53+
private static final String OUTPUT_URI = String.format("gs://%s/%s", PROJECT_ID, PREFIX);
5354

5455
private ByteArrayOutputStream bout;
5556
private PrintStream out;
@@ -103,6 +104,9 @@ public void setUp() {
103104
out = new PrintStream(bout);
104105
originalPrintStream = System.out;
105106
System.setOut(out);
107+
108+
// clear up bucket before the use to prevent concurrency issue.
109+
cleanUpBucket();
106110
}
107111

108112
@After

translate/snippets/src/test/java/com/example/translate/BatchTranslateTextWithGlossaryTests.java

+7-3
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,14 @@
4242
@RunWith(JUnit4.class)
4343
@SuppressWarnings("checkstyle:abbreviationaswordinname")
4444
public class BatchTranslateTextWithGlossaryTests {
45+
4546
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
4647
private static final String INPUT_URI =
4748
"gs://cloud-samples-data/translation/text_with_glossary.txt";
4849
private static final String GLOSSARY_ID = "DO_NOT_DELETE_TEST_GLOSSARY";
49-
private static final String PREFIX = "BATCH_TRANSLATION_GLOSSARY_OUTPUT/";
50-
private static final String OUTPUT_URI =
51-
String.format("gs://%s/%s%s/", PROJECT_ID, PREFIX, UUID.randomUUID());
50+
private static final String PREFIX =
51+
String.format("translation-%s/%s", UUID.randomUUID(), "BATCH_TRANSLATION_GLOSSARY_OUTPUT/");
52+
private static final String OUTPUT_URI = String.format("gs://%s/%s", PROJECT_ID, PREFIX);
5253

5354
private ByteArrayOutputStream bout;
5455
private PrintStream out;
@@ -101,6 +102,9 @@ public void setUp() {
101102
out = new PrintStream(bout);
102103
originalPrintStream = System.out;
103104
System.setOut(out);
105+
106+
// clear up bucket before the use to prevent concurrency issue.
107+
cleanUpBucket();
104108
}
105109

106110
@After

translate/snippets/src/test/java/com/example/translate/BatchTranslateTextWithModelTests.java

+7-3
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,14 @@
4242
@RunWith(JUnit4.class)
4343
@SuppressWarnings("checkstyle:abbreviationaswordinname")
4444
public class BatchTranslateTextWithModelTests {
45+
4546
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
4647
private static final String INPUT_URI =
4748
"gs://cloud-samples-data/translation/custom_model_text.txt";
4849
private static final String MODEL_ID = "TRL3645318651705294848";
49-
private static final String PREFIX = "BATCH_TRANSLATION_MODEL_GLOS_OUTPUT/";
50-
private static final String OUTPUT_URI =
51-
String.format("gs://%s/%s%s/", PROJECT_ID, PREFIX, UUID.randomUUID());
50+
private static final String PREFIX =
51+
String.format("translation-%s/%s", UUID.randomUUID(), "BATCH_TRANSLATION_MODEL_GLOS_OUTPUT/");
52+
private static final String OUTPUT_URI = String.format("gs://%s/%s", PROJECT_ID, PREFIX);
5253

5354
private ByteArrayOutputStream bout;
5455
private PrintStream out;
@@ -98,6 +99,9 @@ public void setUp() {
9899
out = new PrintStream(bout);
99100
originalPrintStream = System.out;
100101
System.setOut(out);
102+
103+
// clear up bucket before the use to prevent concurrency issue.
104+
cleanUpBucket();
101105
}
102106

103107
@After

0 commit comments

Comments
 (0)