Skip to content

Commit 25b3c92

Browse files
authored
Pdt search updates (#1473)
* Update to use shared data bucket for import test in Product Search * Include note for Similar Product Search * Fix test failures * Fix the tests and use a static indexed csv like the other languages
1 parent ae88f82 commit 25b3c92

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

vision/product-search/cloud-client/src/test/java/com/example/vision/ImportProductSetsIT.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public class ImportProductSetsIT {
3434
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
3535
private static final String COMPUTE_REGION = "us-west1";
3636
private static final String GCS_URI =
37-
"gs://java-docs-samples-testing/product-search/product_sets.csv";
37+
"gs://cloud-samples-data/vision/product_search/product_sets.csv";
3838
private static final String PRODUCT_SET_ID = "fake_product_set_id_for_testing";
3939
private static final String PRODUCT_ID_1 = "fake_product_id_for_testing_1";
4040
private static final String PRODUCT_ID_2 = "fake_product_id_for_testing_2";

vision/product-search/cloud-client/src/test/java/com/example/vision/ProductSearchIT.java

+5-8
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,21 @@
2626
import org.junit.runner.RunWith;
2727
import org.junit.runners.JUnit4;
2828

29-
/** Integration (system) tests for {@link ProductSearch}. */
29+
/**
30+
* Integration (system) tests for {@link ProductSearch}.Tests rely on pre-created product set
31+
* that has been indexed.
32+
**/
3033
@RunWith(JUnit4.class)
3134
@SuppressWarnings("checkstyle:abbreviationaswordinname")
3235
public class ProductSearchIT {
3336
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
3437
private static final String COMPUTE_REGION = "us-west1";
35-
private static final String GCS_URI =
36-
"gs://java-docs-samples-testing/product-search/indexed_product_sets.csv";
3738
private static final String PRODUCT_SET_ID = "indexed_product_set_id_for_testing";
3839
private static final String PRODUCT_CATEGORY = "apparel";
3940
private static final String PRODUCT_ID_1 = "indexed_product_id_for_testing_1";
4041
private static final String PRODUCT_ID_2 = "indexed_product_id_for_testing_2";
4142
private static final String IMAGE_URI_1 =
42-
"gs://java-docs-samples-testing/product-search/shoes_1.jpg";
43+
"gs://cloud-samples-data/vision/product_search/shoes_1.jpg";
4344
private static final String FILE_PATH_1 = "./resources/shoes_1.jpg";
4445
private static final String FILTER = "style=womens";
4546
private ByteArrayOutputStream bout;
@@ -51,15 +52,11 @@ public void setUp() throws Exception {
5152
bout = new ByteArrayOutputStream();
5253
out = new PrintStream(bout);
5354
System.setOut(out);
54-
ImportProductSets.importProductSets(PROJECT_ID, COMPUTE_REGION, GCS_URI);
5555
bout.reset();
5656
}
5757

5858
@After
5959
public void tearDown() throws Exception {
60-
ProductManagement.deleteProduct(PROJECT_ID,COMPUTE_REGION,PRODUCT_ID_1);
61-
ProductManagement.deleteProduct(PROJECT_ID,COMPUTE_REGION,PRODUCT_ID_2);
62-
ProductSetManagement.deleteProductSet(PROJECT_ID, COMPUTE_REGION, PRODUCT_SET_ID);
6360
System.setOut(null);
6461
}
6562

0 commit comments

Comments
 (0)