Skip to content

fix: enable typed function compatibility with http signature #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

garethgeorge
Copy link
Contributor

Validation in lib/functions_framework/cli.rb prevents typed functions from working with the http signature type which is set in production. This change enables the typed signature to be used on GCP.

@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@garethgeorge garethgeorge force-pushed the garethgeorge/typed branch 6 times, most recently from e09dd19 to a9a20ed Compare June 23, 2023 18:46
@garethgeorge
Copy link
Contributor Author

@dazuma Updated PR with conformance test coverage to ensure we're exercising the newly relaxed cli checks on the signature type.

@garethgeorge garethgeorge merged commit 3381d5f into main Jun 27, 2023
@garethgeorge garethgeorge deleted the garethgeorge/typed branch June 27, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants