-
Notifications
You must be signed in to change notification settings - Fork 44
feat: implement typed function signature #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a4e328b
to
e4c539b
Compare
e4c539b
to
67d6a9f
Compare
c8aa3e7
to
998b77e
Compare
998b77e
to
63281f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking much nicer now. Can you also add typed
to the test framework (lib/functions_framework/testing.rb
)? You can pretty much just copy call_http
and test for :typed
rather than :http
and change a few names and yardoc comments.
bd7d270
to
43935ef
Compare
43935ef
to
7ee409d
Compare
4be4f18
to
17b9496
Compare
Thanks for the review @dazuma! Added support for the typed signature in the testing package. |
Provide a strongly typed function signature for the ruby functions framework. The strongly typed function signature will provide JSON request deserialization and JSON response serialization by default. It may additionally be used with types implementing
decode_json
andto_json
.