Skip to content

Commit a853e0f

Browse files
authored
fix: add 'version' input to GitHub action (#82)
* fix: add 'version' input to GitHub action This allows specifying a GitHub action version independent from the conformance test (client) version and fixes the issue where conformance tests are being updated even when specifying an older Action release. Note, that GitHub Actions recommends placing the Action in a separate repo, so it may be worth moving `/actions` into its own repo at some point: https://docs.github.com/en/actions/creating-actions/about-custom-actions#choosing-a-location-for-your-action
1 parent 05e150e commit a853e0f

File tree

5 files changed

+15
-5
lines changed

5 files changed

+15
-5
lines changed

action/README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,14 @@
33
This action runs the Functions Framework conformance tests with the specified
44
parameters.
55

6-
Requires Go to be installed prior to running (e.g. actions/setup-go).
6+
Requires Go 1.16+ to be installed prior to running (e.g. actions/setup-go).
77

88
## Inputs
99

10+
### `version`
11+
12+
The version of conformance tests to run. Default `latest`.
13+
1014
### `cmd`
1115

1216
The command to be run.
@@ -27,6 +31,7 @@ Whether or not to validate legacy->cloudevent mapping and vice versa. Default
2731
uses: actions/setup-go@v1
2832
uses: GoogleCloudPlatform/functions-framework-conformance/actions@v1
2933
with:
34+
version: 'v1.0.0'
3035
functionType: 'http'
3136
validateMapping: false
3237
source: 'testdata/testfunc.go'

action/action.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
name: 'Run conformance tests'
22
description: 'Run the functions framework conformance tests with specified parameters.'
33
inputs:
4+
version:
5+
description: 'version of the conformance tests to run'
6+
default: 'latest'
47
outputFile:
5-
description: 'output file from funciton'
8+
description: 'output file from function'
69
default: 'function_output.json'
710
functionType:
811
description: 'type of function'

action/dist/index.js

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)