Skip to content

Commit a9a96f3

Browse files
fix(parametermanager): update files & methods name and testcases
1 parent 39862f1 commit a9a96f3

11 files changed

+49
-50
lines changed

parametermanager/ParameterManager.Samples.Tests/CreateParamWithKmsKeyTests.cs parametermanager/api/ParameterManager.Samples.Tests/CreateParameterWithKmsKeyTests.cs

+7-7
Original file line numberDiff line numberDiff line change
@@ -18,26 +18,26 @@
1818
using Google.Cloud.ParameterManager.V1;
1919

2020
[Collection(nameof(ParameterManagerFixture))]
21-
public class CreateParamWithKmsKeyTests
21+
public class CreateParameterWithKmsKeyTests
2222
{
2323
private readonly ParameterManagerFixture _fixture;
24-
private readonly CreateParamWithKmsKeySample _sample;
24+
private readonly CreateParameterWithKmsKeySample _sample;
2525

26-
public CreateParamWithKmsKeyTests(ParameterManagerFixture fixture)
26+
public CreateParameterWithKmsKeyTests(ParameterManagerFixture fixture)
2727
{
2828
_fixture = fixture;
29-
_sample = new CreateParamWithKmsKeySample();
29+
_sample = new CreateParameterWithKmsKeySample();
3030
}
3131

3232
[Fact]
33-
public void CreateParamWithKmsKey()
33+
public void CreateParameterWithKmsKey()
3434
{
3535
ParameterName parameterName = _fixture.ParameterName;
36-
Parameter result = _sample.CreateParamWithKmsKey(
36+
Parameter result = _sample.CreateParameterWithKmsKey(
3737
projectId: parameterName.ProjectId, parameterId: parameterName.ParameterId, kmsKey: _fixture.cryptoKey.Name);
3838

3939
Assert.NotNull(result);
40-
Assert.Equal(result.Name, parameterName.ToString());
40+
Assert.Equal(result.ParameterName.ParameterId, parameterName.ParameterId);
4141
Assert.Equal(result.KmsKey, _fixture.cryptoKey.Name);
4242
}
4343
}

parametermanager/ParameterManager.Samples.Tests/RemoveParamKmsKeyTests.cs parametermanager/api/ParameterManager.Samples.Tests/RemoveParameterKmsKeyTests.cs

+7-7
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,25 @@
1818
using Google.Cloud.ParameterManager.V1;
1919

2020
[Collection(nameof(ParameterManagerFixture))]
21-
public class RemoveParamKmsKeyTests
21+
public class RemoveParameterKmsKeyTests
2222
{
2323
private readonly ParameterManagerFixture _fixture;
24-
private readonly RemoveParamKmsKeySample _sample;
24+
private readonly RemoveParameterKmsKeySample _sample;
2525

26-
public RemoveParamKmsKeyTests(ParameterManagerFixture fixture)
26+
public RemoveParameterKmsKeyTests(ParameterManagerFixture fixture)
2727
{
2828
_fixture = fixture;
29-
_sample = new RemoveParamKmsKeySample();
29+
_sample = new RemoveParameterKmsKeySample();
3030
}
3131

3232
[Fact]
33-
public void RemoveParamKmsKey()
33+
public void RemoveParameterKmsKey()
3434
{
3535
ParameterName parameterName = _fixture.ParameterName;
36-
Parameter result = _sample.RemoveParamKmsKey(
36+
Parameter result = _sample.RemoveParameterKmsKey(
3737
projectId: parameterName.ProjectId, parameterId: parameterName.ParameterId);
3838

3939
Assert.NotNull(result);
40-
Assert.Equal(result.Name, parameterName.ToString());
40+
Assert.Equal(result.ParameterName.ParameterId, parameterName.ParameterId);
4141
}
4242
}

parametermanager/ParameterManager.Samples.Tests/UpdateParamKmsKeyTests.cs parametermanager/api/ParameterManager.Samples.Tests/UpdateParameterKmsKeyTests.cs

+7-7
Original file line numberDiff line numberDiff line change
@@ -18,26 +18,26 @@
1818
using Google.Cloud.ParameterManager.V1;
1919

2020
[Collection(nameof(ParameterManagerFixture))]
21-
public class UpdateParamKmsKeyTests
21+
public class UpdateParameterKmsKeyTests
2222
{
2323
private readonly ParameterManagerFixture _fixture;
24-
private readonly UpdateParamKmsKeySample _sample;
24+
private readonly UpdateParameterKmsKeySample _sample;
2525

26-
public UpdateParamKmsKeyTests(ParameterManagerFixture fixture)
26+
public UpdateParameterKmsKeyTests(ParameterManagerFixture fixture)
2727
{
2828
_fixture = fixture;
29-
_sample = new UpdateParamKmsKeySample();
29+
_sample = new UpdateParameterKmsKeySample();
3030
}
3131

3232
[Fact]
33-
public void UpdateParamKmsKey()
33+
public void UpdateParameterKmsKey()
3434
{
3535
ParameterName parameterName = _fixture.ParameterName;
36-
Parameter result = _sample.UpdateParamKmsKey(
36+
Parameter result = _sample.UpdateParameterKmsKey(
3737
projectId: parameterName.ProjectId, parameterId: parameterName.ParameterId, kmsKey: _fixture.cryptoKey1.Name);
3838

3939
Assert.NotNull(result);
40-
Assert.Equal(result.Name, parameterName.ToString());
40+
Assert.Equal(result.ParameterName.ParameterId, parameterName.ParameterId);
4141
Assert.Equal(result.KmsKey, _fixture.cryptoKey1.Name);
4242
}
4343
}

parametermanager/ParameterManager.Samples/CreateParamWithKmsKey.cs parametermanager/api/ParameterManager.Samples/CreateParameterWithKmsKey.cs

+10-10
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,17 @@
1919
using Google.Api.Gax.ResourceNames;
2020
using Google.Cloud.ParameterManager.V1;
2121

22-
/// <summary>
23-
/// This function creates a parameter with kms_key using the Parameter Manager SDK for GCP.
24-
/// </summary>
25-
/// <param name="projectId">The ID of the project where the parameter is to be created.</param>
26-
/// <param name="parameterId">The ID to assign to the new parameter. This ID must be unique within the project.</param>
27-
/// <param name="kmsKey">The ID of the KMS key to be used for encryption.
28-
/// (e.g. "projects/my-project/locations/global/keyRings/my-key-ring/cryptoKeys/my-encryption-key")</param>
29-
/// <returns>The created Parameter object.</returns>
30-
public class CreateParamWithKmsKeySample
22+
public class CreateParameterWithKmsKeySample
3123
{
32-
public Parameter CreateParamWithKmsKey(
24+
/// <summary>
25+
/// This function creates a parameter with kms_key using the Parameter Manager SDK for GCP.
26+
/// </summary>
27+
/// <param name="projectId">The ID of the project where the parameter is to be created.</param>
28+
/// <param name="parameterId">The ID to assign to the new parameter. This ID must be unique within the project.</param>
29+
/// <param name="kmsKey">The ID of the KMS key to be used for encryption.
30+
/// (e.g. "projects/my-project/locations/global/keyRings/my-key-ring/cryptoKeys/my-encryption-key")</param>
31+
/// <returns>The created Parameter object.</returns>
32+
public Parameter CreateParameterWithKmsKey(
3333
string projectId,
3434
string parameterId,
3535
string kmsKey)

parametermanager/ParameterManager.Samples/ParameterManager.Samples.csproj parametermanager/api/ParameterManager.Samples/ParameterManager.Samples.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<PackageReference Include="Google.Cloud.Common" Version="2.2.0" />
1211
<PackageReference Include="Google.Cloud.ParameterManager.V1" Version="1.0.0-beta02" />
1312
</ItemGroup>
1413
</Project>

parametermanager/ParameterManager.Samples/RemoveParamKmsKey.cs parametermanager/api/ParameterManager.Samples/RemoveParameterKmsKey.cs

+8-8
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@
2020
using Google.Cloud.ParameterManager.V1;
2121
using Google.Protobuf.WellKnownTypes;
2222

23-
/// <summary>
24-
/// This function Removes a kms_key for parameter using the Parameter Manager SDK for GCP.
25-
/// </summary>
26-
/// <param name="projectId">The ID of the project where the parameter is to be created.</param>
27-
/// <param name="parameterId">The ID to assign to the new parameter. This ID must be unique within the project.</param>
28-
/// <returns>The Parameter object.</returns>
29-
public class RemoveParamKmsKeySample
23+
public class RemoveParameterKmsKeySample
3024
{
31-
public Parameter RemoveParamKmsKey(
25+
/// <summary>
26+
/// This function Removes a kms_key for parameter using the Parameter Manager SDK for GCP.
27+
/// </summary>
28+
/// <param name="projectId">The ID of the project where the parameter is to be created.</param>
29+
/// <param name="parameterId">The ID to assign to the new parameter. This ID must be unique within the project.</param>
30+
/// <returns>The Parameter object.</returns>
31+
public Parameter RemoveParameterKmsKey(
3232
string projectId,
3333
string parameterId)
3434
{

parametermanager/ParameterManager.Samples/UpdateParamKmsKey.cs parametermanager/api/ParameterManager.Samples/UpdateParameterKmsKey.cs

+10-10
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,17 @@
2020
using Google.Cloud.ParameterManager.V1;
2121
using Google.Protobuf.WellKnownTypes;
2222

23-
/// <summary>
24-
/// This function updates a parameter with kms_key using the Parameter Manager SDK for GCP.
25-
/// </summary>
26-
/// <param name="projectId">The ID of the project where the parameter is to be updated.</param>
27-
/// <param name="parameterId">The ID to assign to the new parameter. This ID must be unique within the project.</param>
28-
/// <param name="kmsKey">The ID of the KMS key to be used for encryption.
29-
/// (e.g. "projects/my-project/locations/global/keyRings/my-key-ring/cryptoKeys/my-encryption-key")</param>
30-
/// <returns>The updated Parameter object.</returns>
31-
public class UpdateParamKmsKeySample
23+
public class UpdateParameterKmsKeySample
3224
{
33-
public Parameter UpdateParamKmsKey(
25+
/// <summary>
26+
/// This function updates a parameter with kms_key using the Parameter Manager SDK for GCP.
27+
/// </summary>
28+
/// <param name="projectId">The ID of the project where the parameter is to be updated.</param>
29+
/// <param name="parameterId">The ID to assign to the new parameter. This ID must be unique within the project.</param>
30+
/// <param name="kmsKey">The ID of the KMS key to be used for encryption.
31+
/// (e.g. "projects/my-project/locations/global/keyRings/my-key-ring/cryptoKeys/my-encryption-key")</param>
32+
/// <returns>The updated Parameter object.</returns>
33+
public Parameter UpdateParameterKmsKey(
3434
string projectId,
3535
string parameterId,
3636
string kmsKey)
File renamed without changes.

0 commit comments

Comments
 (0)