Skip to content

Commit 982f2c2

Browse files
authored
Fixing failing deployment on GHA to deploy to GKE (wrong skaffold flag removed). (#51)
Add role to deployment service account, otherwise it fails on permission denied when running setup/setup_ksa.sh script
1 parent 8adb957 commit 982f2c2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/deployment_gke_dev.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ jobs:
7373
--profile gke \
7474
-l commit=$GITHUB_SHA \
7575
--namespace $SKAFFOLD_NAMESPACE \
76-
--tag latest \
77-
--add-skaffold-labels=false
76+
--tag latest
7877
7978
- name: Upload Skaffold cache
8079
if: always()

terraform/stages/2-foundation/main.tf

+1
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ module "deployment_service_account" {
115115
"roles/firebase.admin",
116116
"roles/iam.serviceAccountTokenCreator",
117117
"roles/iam.serviceAccountUser",
118+
"iam.serviceAccountAdmin",
118119
"roles/iam.workloadIdentityUser",
119120
"roles/logging.admin",
120121
"roles/logging.viewer",

0 commit comments

Comments
 (0)