Skip to content

Commit 0d49965

Browse files
author
Robert Koehlmoos
authored
Merge pull request #58 from RobertKoehlmoos/670-feature-display-image-references
670 feature display image references
2 parents f7d8128 + e38078c commit 0d49965

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

components/frontend_react/webapp/src/components/query/References.tsx

+9-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const References: React.FC<ReferencesProps> = ({ references }) => {
2626
const map = new Map<string, T>()
2727
items.forEach(item => {
2828
const key: string = String(item[dedupKey])
29-
map.set(key, item)
29+
map.set(key, item)
3030
})
3131
return Array.from(map.values())
3232
}
@@ -37,6 +37,8 @@ const References: React.FC<ReferencesProps> = ({ references }) => {
3737
.replace("/b/", "https://storage.googleapis.com/")
3838
.replace("/o/", "/")
3939
}
40+
if (url.startsWith("gs://"))
41+
return url.replace("gs://", "https://storage.googleapis.com/")
4042
return url
4143
}
4244

@@ -91,7 +93,12 @@ const References: React.FC<ReferencesProps> = ({ references }) => {
9193
className="text-info hover:text-info-content break-all transition-colors mr-1.5">
9294
{renderLinkTitle(ref.document_url)}:
9395
</a>
94-
<Markdown children={truncateText(ref.document_text)} rehypePlugins={[rehypeRaw]} />
96+
{ref?.modality === "image" ?
97+
<img src={renderCloudStorageUrl(ref.chunk_url)} /> :
98+
// if the modality is not image assume it is text to handle
99+
// legacy query engines that didn't set a modality
100+
<Markdown children={truncateText(ref.document_text)} rehypePlugins={[rehypeRaw]} />
101+
}
95102
</span>
96103
<div className={index < uniqueReferences.length - 1 ? "mx-2 pt-3 border-b" : ""} />
97104
</div>

components/frontend_react/webapp/src/routes/QueryEngineEdit.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@ const QueryEngineEdit: React.FC<IQueryEngineProps> = ({ token }) => {
185185
useEffect(() => {
186186
const updateEngineEmbeddings = async () => {
187187
const llmTypes = await (await fetchEmbeddingTypes(token, createEngineIsMultimodal))()
188-
console.log(llmTypes)
189188
if (llmTypes === null || llmTypes === undefined) console.error("Failed to retrieve embedding types")
190189
else setCreateEngineEmbeddingOptions(llmTypes.map((embedding) => { return { option: embedding, value: embedding } }))
191190
}

components/frontend_react/webapp/src/utils/types.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,10 @@ export interface QueryResponse {
105105

106106
export interface QueryReferences {
107107
chunk_id: string
108+
chunk_url: string
108109
document_url: string
109110
document_text: string
111+
modality: string
110112
}
111113

112114
export type QueryContents = {
@@ -243,5 +245,5 @@ export type QueryEngineBuildJob = {
243245
output_gcs_path: any
244246
errors: any
245247
job_logs: any
246-
metadata: any
248+
metadata: any
247249
}

0 commit comments

Comments
 (0)