Skip to content

Argument is deprecated #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IanMoroney opened this issue Aug 19, 2024 · 3 comments
Closed

Argument is deprecated #2506

IanMoroney opened this issue Aug 19, 2024 · 3 comments

Comments

@IanMoroney
Copy link

I understand this is fixed now according to this pr, just tracking here for completion.
If you could close this in the next release that would be great πŸ‘

β”‚ Warning: Argument is deprecated
β”‚ 
β”‚   with module.domain-projects["myproject"].google_project.project[0],
β”‚   on .terraform/modules/domain-projects/cloud-foundation-fabric-32.0.0/modules/project/main.tf line 53, in resource "google_project" "project":
β”‚   53:   skip_delete         = var.skip_delete
β”‚ 
β”‚ skip_delete is deprecated and will be removed in 6.0.0. Please use deletion_policy instead. A skip_delete value of false can be changed to a deletion_policy value
β”‚ of DELETE and a skip_delete value of true to a deletion_policy value of ABANDON for equivalent behavior.
@juliocc
Copy link
Collaborator

juliocc commented Aug 19, 2024

This is already fixed. What is the ask here?

@IanMoroney
Copy link
Author

it's not released yet, right? it wasn't included in v33.0.0

@ludoo
Copy link
Collaborator

ludoo commented Aug 19, 2024

it's not released yet, right? it wasn't included in v33.0.0

We don't keep issues open for features already implemented, which will go in the next release. :) It's not needed (they will go in the release regardless), and it would make issues unusable to track actual bugs/FRs.

@ludoo ludoo closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants