-
Notifications
You must be signed in to change notification settings - Fork 982
Tenant factory missing automation support? #2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ach, early morning replies with no coffee... :) [deleted] |
Yes, the tenant factory stage is currently missing a workflow file. But... it's identical to the resource management stage except for its providers file, which uses a path in the GCS backend. You could just copy/paste the resman workflow file, and change one line so that the workflow copies the correct providers file. But then you'd need to also assign the correct impersonation permissions on the automation service accounts... I will add support for this to bootstrap, thanks for flagging. |
@pbrumblay I'm closing this as the above PR should fix it. Please reopen if you run into issues (which is possible as the tenant factory is new), and again thanks again for reporting this! |
Thank you @ludoo! I will check it out. |
Describe the bug
I'm trying to use the new tenant-factory feature and I was looking for automation support similar to what exists for the 1-resman stage. I didn't find what I would expect. I am trying to understand the intent but am probably failing.
Expected Result
My goal: I want to make a change to a file like
1-tenant-factory.auto.tfvars
to add / remove tenants and have a github workflow kick off to modify the tenants.I expected to find functionality for tenant-factory automation similar to this PR in my fork: https://github.com/pbrumblay/tyr-fabric/pull/1/files.
I don't like the copy/paste implementation, but with it I'm able to change the tenant-factory configuration to kick off a GH workflow to add / remove tenants. Should I be thinking about this in a different way?
Note: I think the
1-tenant-factory
addition for multi-tenancy was a great move overall so thank you to @ludoo for that.Environment
The text was updated successfully, but these errors were encountered: