Skip to content

Tenant factory missing automation support? #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pbrumblay opened this issue May 20, 2024 · 4 comments · Fixed by #2297
Closed

Tenant factory missing automation support? #2295

pbrumblay opened this issue May 20, 2024 · 4 comments · Fixed by #2297
Assignees

Comments

@pbrumblay
Copy link
Contributor

pbrumblay commented May 20, 2024

Describe the bug
I'm trying to use the new tenant-factory feature and I was looking for automation support similar to what exists for the 1-resman stage. I didn't find what I would expect. I am trying to understand the intent but am probably failing.

Expected Result
My goal: I want to make a change to a file like 1-tenant-factory.auto.tfvars to add / remove tenants and have a github workflow kick off to modify the tenants.

I expected to find functionality for tenant-factory automation similar to this PR in my fork: https://github.com/pbrumblay/tyr-fabric/pull/1/files.

I don't like the copy/paste implementation, but with it I'm able to change the tenant-factory configuration to kick off a GH workflow to add / remove tenants. Should I be thinking about this in a different way?

Note: I think the 1-tenant-factory addition for multi-tenancy was a great move overall so thank you to @ludoo for that.

Environment

Terraform v1.8.3
on darwin_arm64
0afaa84
@ludoo
Copy link
Collaborator

ludoo commented May 21, 2024

Ach, early morning replies with no coffee... :) [deleted]

@ludoo ludoo closed this as completed May 21, 2024
@ludoo ludoo reopened this May 21, 2024
@ludoo
Copy link
Collaborator

ludoo commented May 21, 2024

Yes, the tenant factory stage is currently missing a workflow file. But... it's identical to the resource management stage except for its providers file, which uses a path in the GCS backend.

You could just copy/paste the resman workflow file, and change one line so that the workflow copies the correct providers file. But then you'd need to also assign the correct impersonation permissions on the automation service accounts...

I will add support for this to bootstrap, thanks for flagging.

@ludoo
Copy link
Collaborator

ludoo commented May 21, 2024

@pbrumblay I'm closing this as the above PR should fix it. Please reopen if you run into issues (which is possible as the tenant factory is new), and again thanks again for reporting this!

@ludoo ludoo closed this as completed May 21, 2024
@pbrumblay
Copy link
Contributor Author

Thank you @ludoo! I will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants