GKE Multitenant Blueprint - logging configuration

[olliefr]

Hey,

While working on #1638 I had noticed that the README for GKE Multitenant Blueprint states:

cloud-foundation-fabric/blueprints/gke/multitenant-fleet/README.md

Line 16 in 2e0474d

- Logging and monitoring configured to use Cloud Operations for system components and user workloads.

My interpretation of this is such that both SYSTEM_COMPONENTS and WORKLOADS logs are being ingested as per LoggingComponentConfig.

The examples in the blueprint README do not include any logging configuration so it falls back to the default value, which is defined to be system logs only:

cloud-foundation-fabric/blueprints/gke/multitenant-fleet/variables.tf

Line 36 in 2e0474d

logging_config = optional(list(string), ["SYSTEM_COMPONENTS"])

I think this is a divergence from what's stated in the README and either the README or the default value must be corrected.

I'm interested to know what, in your opinion, the answer should be so that I can update #1638 🙃

Default logging in Cloud Console vs gke-cluster-standard

I think this might be a consequence of a bigger point although I am not sure if it warrants a separate issue - in Cloud Console, pre-selected values for logging configuration are system logs and workloads, indeed.

In gke-cluster-standard as it stands today, the default value is system logs only.

I'm not sure if this divergence is intentional.

[olliefr]

While working on updating the example for using the new logging_config interface in #1638, I'd updated the example to also include WORKLOADS in the logs source.

Thus, once #1638 is merged there is going to be no discrepancy between the README and the code.

Commit: fe13131