Skip to content

Feat req: Automatic HTTP to HTTPS redirect in "net-lb-app-ext" module #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
francesco-pavan-huware opened this issue Aug 7, 2023 · 5 comments · Fixed by #1719
Closed

Comments

@francesco-pavan-huware
Copy link
Contributor

Hi,

I'm creating an External HTTPS Load Balancer using the "net-lb-app-ext" module. It would be very convenient, as it happens in the Google Cloud GUI Console, to have an option to automatically create an additional Load Balancer that redirects requests from HTTP to HTTPS. Currently, the only way to implement this feature is to create a second LB manually with the same module and correctly configuring the routing rules to perform the redirect.

Would it be possible to implement this feature in the future please?

Kind regards,
Francesco

@juliocc
Copy link
Collaborator

juliocc commented Aug 7, 2023

I don't like the idea of automagically creating another LB. If you really want it you can easily instantiate the module again and build the redirect manually.

Explicit is better than implicit.

@ludoo
Copy link
Collaborator

ludoo commented Aug 7, 2023

Agree with Julio 100%, we can keep this open to add an example implementation to the module's README, or close it.

@francesco-pavan-huware
Copy link
Contributor Author

Hi,

thanks a lot for the replies. I actually agree with you that explicit is always better than implicit and therefore magically creating a new load balancer is perhaps not the best way, however, being a feature present on the GUI console, I believe that many users are used to this possibility and that perhaps it would not be so "risky" a change like that, what do you think?

In any case a mention and an example inside the README are surely a valid solution.

Francesco

@ludoo
Copy link
Collaborator

ludoo commented Aug 7, 2023

Well, UI and IaC are kind of different worlds so we don't need to replicate what the UI does. :)

@francesco-pavan-huware
Copy link
Contributor Author

Ok, thanks a lot. If that's okay with you, we can leave the issue open to add an example to the module README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants