Skip to content

allow_net_admin unsupported in gke-cluster-autopilot #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eunanio opened this issue Aug 5, 2023 · 5 comments · Fixed by #1575
Closed

allow_net_admin unsupported in gke-cluster-autopilot #1571

eunanio opened this issue Aug 5, 2023 · 5 comments · Fixed by #1575

Comments

@eunanio
Copy link
Contributor

eunanio commented Aug 5, 2023

Unable to enable NET_ADMIN feature in autopilot module

  • expose allow_net_admin in google_container_cluster
  • add variable for allow_net_admin to gke-cluster-autopilot

Feature in magic modules

Code Example

# gke-cluster-autopilot/main.tf
resource "google_container_cluster" "cluster" {
  provider        = google-beta
  project         = var.project_id
  name            = var.name
  description     = var.description
  location        = var.location
  allow_net_admin = var.allow_net_admin
  node_locations = (
    length(var.node_locations) == 0 ? null : var.node_locations
  )
...
# gke-cluster-autopilot/variables.tf 
variable "allow_net_admin" {
  description = "Whether to enable NET_ADMIN feature."
  type        = bool
  default     = false
}
@juliocc
Copy link
Collaborator

juliocc commented Aug 6, 2023

This field was added in version 4.76.0 of the provider

@eunanio
Copy link
Contributor Author

eunanio commented Aug 7, 2023

Can I be given permission to raise this as a pull request?

@juliocc
Copy link
Collaborator

juliocc commented Aug 7, 2023

Please do, you don't need any permissions to open a PR.

@eunanio
Copy link
Contributor Author

eunanio commented Aug 7, 2023

Ive been unable to push my branch eunanhardy/add-net-admin-autopilot. keeps telling me I dont have permission and should fork. Ive verified that I am logged in on all git clients and tried multiple times any suggestions?

@juliocc
Copy link
Collaborator

juliocc commented Aug 7, 2023

Yes, create a fork and submit your pull request from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants