Skip to content

Switch to generated AlloyDBAdminAsyncClient over aiohttp.ClientSession #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackwotherspoon opened this issue Jan 18, 2024 · 4 comments · Fixed by #416
Closed

Switch to generated AlloyDBAdminAsyncClient over aiohttp.ClientSession #221

jackwotherspoon opened this issue Jan 18, 2024 · 4 comments · Fixed by #416
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jackwotherspoon
Copy link
Collaborator

AlloyDB has a generated package with support for an async client. Should look at switching to use it over the aiohttp.ClientSession that is currently being used to hit the admin API endpoints. Will want to investigate performance a bit before committing to this switch in case it degrades the performance.

AlloyDB Client package: https://pypi.org/project/google-cloud-alloydb/

Generated client: https://github.com/googleapis/google-cloud-python/blob/main/packages/google-cloud-alloydb/google/cloud/

@jackwotherspoon jackwotherspoon added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 18, 2024
@jackwotherspoon jackwotherspoon self-assigned this Jan 18, 2024
@enocom enocom assigned enocom and unassigned jackwotherspoon Sep 6, 2024
@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 6, 2024
@RahulDubey391
Copy link
Contributor

Hi @enocom @jackwotherspoon , if this feature development is on halt, can I start working it? Or let me know if other is on priority which I can take

@jackwotherspoon
Copy link
Collaborator Author

@RahulDubey391 Thanks for the interest here 😄

I will let @enocom make the decision as he is now the owner of this library.

My two cents atleast is that it doesn't hurt to get a working draft PR that uses the AlloyDBAdminAsyncClient over the current aiohttp client. This will let us then run some tests to see if there is any performance differences between the different clients. The one thing to keep in mind @RahulDubey391 is that if the generated client performs worse we may not end up merging the PR, just something to be aware of before you commit time.

@enocom The nice side of switching over to the generated client is that you will get some free benefits like universe_domain support etc which I think is in the future work of this library anyway. (code ref)

@jackwotherspoon
Copy link
Collaborator Author

@RahulDubey391 Another good potential task would be #245 for async token refresh, it is a bit more straightforward in my eyes

@RahulDubey391
Copy link
Contributor

Okay @jackwotherspoon , I'll do the analysis and get back to you. Will raise a PR with the remarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
4 participants