Skip to content

Assets from gstatic.com & googleapis.com should also be excluded from audit results #11134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carl-alberto opened this issue Jul 21, 2020 · 3 comments

Comments

@carl-alberto
Copy link

Provide the steps to reproduce

  1. Run LH on https://developers.google.com/speed/pagespeed/insights/?url=games.lol (or any sites that has gstatic.com or googleapis.com assets)

What is the current behavior?

Google assets from gstatic.com or googleapis.com do no follow their own audit rules and being flagged in Lighthouse

Screen Shot 2020-07-21 at 8 34 57 PM

Screen Shot 2020-07-21 at 8 49 06 PM

What is the expected behavior?

As per issue #6140, Google assets do no follow their own audit rules and should be excluded, but gstatic.com & googleapis.com seems not to be included on the excluded assets raised from that GH issues, should they also be excluded too?

Environment Information

  • Affected Channels: DevTools
  • Lighthouse version: 6.1.0

Related issues
#6140
Possibly also related:
#4516
#9256
#8955

@brendankenny
Copy link
Contributor

As per issue #6140, Google assets do no follow their own audit rules and should be excluded, but gstatic.com & googleapis.com seems not to be included on the excluded assets raised from that GH issues, should they also be excluded too?

Hi @carl-alberto, I think maybe the discussion in #6140 was misconstrued? The decision was not to exclude assets from gstatic from the Lighthouse report, it was to make sure they could be hidden by unchecking the "Show 3rd party resources" checkbox to see things from just the origin being tested. Resources from Google aren't treated any differently than resources from anywhere else for the render-blocking audit.

As for the checkbox, I'm not able to reproduce the behavior you have in your screenshot when I run against that site in DevTools. The checkbox is available and correctly filters out the resources from gstatic and cloudfront if unchecked.

render-blocking Lighthouse audit screenshot

@carl-alberto
Copy link
Author

carl-alberto commented Jul 21, 2020

Thanks for the reply @brendankenny

any reason why the checkbox for "show 3rd-party resources" enabled only from the eliminate render-blocking resources section only

Screen Shot 2020-07-21 at 10 32 29 PM

And not available under remove unused javascript section
Screen Shot 2020-07-21 at 10 34 42 PM

@patrickhulce
Copy link
Collaborator

@carl-alberto the checkbox will be disabled when all resources in the table are 3rd party resources, i.e. we don't allow you to filter down to an empty table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants