Skip to content

Commit 0e513a6

Browse files
connorjclarkpaulirish
connorjclark
authored and
paulirish
committed
report(redesign): remove units from table column headings (#8658)
1 parent 623b789 commit 0e513a6

File tree

4 files changed

+31
-33
lines changed

4 files changed

+31
-33
lines changed

‎lighthouse-core/lib/i18n/en-US.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1196,7 +1196,7 @@
11961196
"description": "Label for the TTL column in data tables, entries will be the time to live value of the cache header on a web resource"
11971197
},
11981198
"lighthouse-core/lib/i18n/i18n.js | columnSize": {
1199-
"message": "Size (KB)",
1199+
"message": "Size",
12001200
"description": "Label for the size column in data tables, entries will be the size of a web resource in kilobytes"
12011201
},
12021202
"lighthouse-core/lib/i18n/i18n.js | columnTimeSpent": {
@@ -1208,11 +1208,11 @@
12081208
"description": "Label for the URL column in data tables, entries will be the URL of a web resource"
12091209
},
12101210
"lighthouse-core/lib/i18n/i18n.js | columnWastedBytes": {
1211-
"message": "Potential Savings (KB)",
1211+
"message": "Potential Savings",
12121212
"description": "Label for the wasted bytes column in data tables, entries will be the number of kilobytes the user could reduce their page by if they implemented the suggestions"
12131213
},
12141214
"lighthouse-core/lib/i18n/i18n.js | columnWastedMs": {
1215-
"message": "Potential Savings (ms)",
1215+
"message": "Potential Savings",
12161216
"description": "Label for the wasted bytes column in data tables, entries will be the number of milliseconds the user could reduce page load by if they implemented the suggestions"
12171217
},
12181218
"lighthouse-core/lib/i18n/i18n.js | displayValueByteSavings": {

‎lighthouse-core/lib/i18n/i18n.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ const UIStrings = {
4747
/** Label for the URL column in data tables, entries will be the URL of a web resource */
4848
columnURL: 'URL',
4949
/** Label for the size column in data tables, entries will be the size of a web resource in kilobytes */
50-
columnSize: 'Size (KB)',
50+
columnSize: 'Size',
5151
/** Label for the TTL column in data tables, entries will be the time to live value of the cache header on a web resource */
5252
columnCacheTTL: 'Cache TTL',
5353
/** Label for the wasted bytes column in data tables, entries will be the number of kilobytes the user could reduce their page by if they implemented the suggestions */
54-
columnWastedBytes: 'Potential Savings (KB)',
54+
columnWastedBytes: 'Potential Savings',
5555
/** Label for the wasted bytes column in data tables, entries will be the number of milliseconds the user could reduce page load by if they implemented the suggestions */
56-
columnWastedMs: 'Potential Savings (ms)',
56+
columnWastedMs: 'Potential Savings',
5757
/** Label for the time spent column in data tables, entries will be the number of milliseconds spent during a particular activity */
5858
columnTimeSpent: 'Time Spent',
5959
};

‎lighthouse-core/test/results/sample_v2.json

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1928,7 +1928,7 @@
19281928
{
19291929
"key": "totalBytes",
19301930
"itemType": "bytes",
1931-
"text": "Size (KB)",
1931+
"text": "Size",
19321932
"displayUnit": "kb",
19331933
"granularity": 1
19341934
}
@@ -2036,7 +2036,7 @@
20362036
{
20372037
"key": "totalBytes",
20382038
"itemType": "bytes",
2039-
"text": "Size (KB)"
2039+
"text": "Size"
20402040
}
20412041
],
20422042
"items": [
@@ -2119,12 +2119,12 @@
21192119
{
21202120
"key": "totalBytes",
21212121
"valueType": "bytes",
2122-
"label": "Size (KB)"
2122+
"label": "Size"
21232123
},
21242124
{
21252125
"key": "wastedMs",
21262126
"valueType": "timespanMs",
2127-
"label": "Potential Savings (ms)"
2127+
"label": "Potential Savings"
21282128
}
21292129
],
21302130
"items": [
@@ -2193,12 +2193,12 @@
21932193
{
21942194
"key": "totalBytes",
21952195
"valueType": "bytes",
2196-
"label": "Size (KB)"
2196+
"label": "Size"
21972197
},
21982198
{
21992199
"key": "wastedBytes",
22002200
"valueType": "bytes",
2201-
"label": "Potential Savings (KB)"
2201+
"label": "Potential Savings"
22022202
}
22032203
],
22042204
"items": [
@@ -2254,12 +2254,12 @@
22542254
{
22552255
"key": "totalBytes",
22562256
"valueType": "bytes",
2257-
"label": "Size (KB)"
2257+
"label": "Size"
22582258
},
22592259
{
22602260
"key": "wastedBytes",
22612261
"valueType": "bytes",
2262-
"label": "Potential Savings (KB)"
2262+
"label": "Potential Savings"
22632263
}
22642264
],
22652265
"items": [
@@ -2311,12 +2311,12 @@
23112311
{
23122312
"key": "totalBytes",
23132313
"valueType": "bytes",
2314-
"label": "Size (KB)"
2314+
"label": "Size"
23152315
},
23162316
{
23172317
"key": "wastedBytes",
23182318
"valueType": "bytes",
2319-
"label": "Potential Savings (KB)"
2319+
"label": "Potential Savings"
23202320
}
23212321
],
23222322
"items": [
@@ -5142,8 +5142,11 @@
51425142
"path": "audits[render-blocking-resources].displayValue"
51435143
}
51445144
],
5145-
"lighthouse-core/lib/i18n/i18n.js | columnWastedMs": [
5146-
"audits[render-blocking-resources].details.headings[2].label"
5145+
"lighthouse-core/lib/i18n/i18n.js | columnWastedBytes": [
5146+
"audits[render-blocking-resources].details.headings[2].label",
5147+
"audits[unminified-javascript].details.headings[2].label",
5148+
"audits[uses-webp-images].details.headings[3].label",
5149+
"audits[uses-text-compression].details.headings[2].label"
51475150
],
51485151
"lighthouse-core/audits/byte-efficiency/unminified-css.js | title": [
51495152
"audits[unminified-css].title"
@@ -5177,11 +5180,6 @@
51775180
"path": "audits[uses-text-compression].displayValue"
51785181
}
51795182
],
5180-
"lighthouse-core/lib/i18n/i18n.js | columnWastedBytes": [
5181-
"audits[unminified-javascript].details.headings[2].label",
5182-
"audits[uses-webp-images].details.headings[3].label",
5183-
"audits[uses-text-compression].details.headings[2].label"
5184-
],
51855183
"lighthouse-core/audits/byte-efficiency/unused-css-rules.js | title": [
51865184
"audits[unused-css-rules].title"
51875185
],

‎proto/sample_v2_round_trip.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2096,12 +2096,12 @@
20962096
},
20972097
{
20982098
"key": "totalBytes",
2099-
"label": "Size (KB)",
2099+
"label": "Size",
21002100
"valueType": "bytes"
21012101
},
21022102
{
21032103
"key": "wastedMs",
2104-
"label": "Potential Savings (ms)",
2104+
"label": "Potential Savings",
21052105
"valueType": "timespanMs"
21062106
}
21072107
],
@@ -2338,7 +2338,7 @@
23382338
{
23392339
"itemType": "bytes",
23402340
"key": "totalBytes",
2341-
"text": "Size (KB)"
2341+
"text": "Size"
23422342
}
23432343
],
23442344
"items": [
@@ -2418,12 +2418,12 @@
24182418
},
24192419
{
24202420
"key": "totalBytes",
2421-
"label": "Size (KB)",
2421+
"label": "Size",
24222422
"valueType": "bytes"
24232423
},
24242424
{
24252425
"key": "wastedBytes",
2426-
"label": "Potential Savings (KB)",
2426+
"label": "Potential Savings",
24272427
"valueType": "bytes"
24282428
}
24292429
],
@@ -2586,7 +2586,7 @@
25862586
"granularity": 1.0,
25872587
"itemType": "bytes",
25882588
"key": "totalBytes",
2589-
"text": "Size (KB)"
2589+
"text": "Size"
25902590
}
25912591
],
25922592
"items": [
@@ -2788,12 +2788,12 @@
27882788
},
27892789
{
27902790
"key": "totalBytes",
2791-
"label": "Size (KB)",
2791+
"label": "Size",
27922792
"valueType": "bytes"
27932793
},
27942794
{
27952795
"key": "wastedBytes",
2796-
"label": "Potential Savings (KB)",
2796+
"label": "Potential Savings",
27972797
"valueType": "bytes"
27982798
}
27992799
],
@@ -2835,12 +2835,12 @@
28352835
},
28362836
{
28372837
"key": "totalBytes",
2838-
"label": "Size (KB)",
2838+
"label": "Size",
28392839
"valueType": "bytes"
28402840
},
28412841
{
28422842
"key": "wastedBytes",
2843-
"label": "Potential Savings (KB)",
2843+
"label": "Potential Savings",
28442844
"valueType": "bytes"
28452845
}
28462846
],

0 commit comments

Comments
 (0)